From 9301070219e832fa388cc335d3287afeb0ebefef Mon Sep 17 00:00:00 2001 From: ShakyaPr Date: Fri, 31 Jan 2025 11:16:59 +0530 Subject: [PATCH 1/2] added save button disbale option --- .../src/app/components/AdminPages/Addons/FormDialogBase.jsx | 5 ++++- .../components/GatewayEnvironments/AddEditGWEnvironment.jsx | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/portals/admin/src/main/webapp/source/src/app/components/AdminPages/Addons/FormDialogBase.jsx b/portals/admin/src/main/webapp/source/src/app/components/AdminPages/Addons/FormDialogBase.jsx index b4f3e45b43e..c736d6be2a5 100644 --- a/portals/admin/src/main/webapp/source/src/app/components/AdminPages/Addons/FormDialogBase.jsx +++ b/portals/admin/src/main/webapp/source/src/app/components/AdminPages/Addons/FormDialogBase.jsx @@ -42,6 +42,7 @@ function FormDialogBase({ formSaveCallback, dialogOpenCallback, triggerIconProps, + saveButtonDisabled, }) { const [open, setOpen] = React.useState(false); const [saving, setSaving] = useState(false); @@ -104,7 +105,7 @@ function FormDialogBase({ onClick={saveTriggerd} color='primary' variant='contained' - disabled={saving} + disabled={saving || saveButtonDisabled} data-testid='form-dialog-base-save-btn' > {saving ? () : (<>{saveButtonText})} @@ -124,6 +125,7 @@ FormDialogBase.defaultProps = { color: 'primary', component: 'span', }, + saveButtonDisabled: false, }; FormDialogBase.propTypes = { @@ -142,6 +144,7 @@ FormDialogBase.propTypes = { triggerIconProps: PropTypes.shape({}), formSaveCallback: PropTypes.func.isRequired, dialogOpenCallback: PropTypes.func, + saveButtonDisabled: PropTypes.bool, }; export default FormDialogBase; diff --git a/portals/admin/src/main/webapp/source/src/app/components/GatewayEnvironments/AddEditGWEnvironment.jsx b/portals/admin/src/main/webapp/source/src/app/components/GatewayEnvironments/AddEditGWEnvironment.jsx index 55d71ba148b..1ad2842f115 100644 --- a/portals/admin/src/main/webapp/source/src/app/components/GatewayEnvironments/AddEditGWEnvironment.jsx +++ b/portals/admin/src/main/webapp/source/src/app/components/GatewayEnvironments/AddEditGWEnvironment.jsx @@ -498,6 +498,7 @@ function AddEditGWEnvironment(props) { triggerButtonText={triggerButtonText} formSaveCallback={formSaveCallback} dialogOpenCallback={dialogOpenCallback} + saveButtonDisabled={!roleValidity} > Date: Fri, 31 Jan 2025 14:32:42 +0530 Subject: [PATCH 2/2] Added save btn disable option for invalid roles - key manager --- .../source/src/app/components/KeyManagers/AddEditKeyManager.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/portals/admin/src/main/webapp/source/src/app/components/KeyManagers/AddEditKeyManager.jsx b/portals/admin/src/main/webapp/source/src/app/components/KeyManagers/AddEditKeyManager.jsx index 78bf7a54c98..03ae38b72a7 100644 --- a/portals/admin/src/main/webapp/source/src/app/components/KeyManagers/AddEditKeyManager.jsx +++ b/portals/admin/src/main/webapp/source/src/app/components/KeyManagers/AddEditKeyManager.jsx @@ -2154,7 +2154,7 @@ function AddEditKeyManager(props) { variant='contained' color='primary' onClick={formSaveCallback} - disabled={isGlobal && !isSuperAdmin} + disabled={(isGlobal && !isSuperAdmin) || !roleValidity} > {saving ? () : ( <>