Replace addIdPCacheOnRead with addIdPCache for write paths

Author: Zeta201

components/idp-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java

@@ -338,7 +338,7 @@ public IdentityProvider getIdPByResourceId(String resourceId, int tenantId, Stri
                     tenantId, tenantDomain);
 
             if (identityProvider != null) {
-                addIdPCacheOnRead(identityProvider, tenantDomain);
+                addIdPCache(identityProvider, tenantDomain);
             } else {
                 if (log.isDebugEnabled()) {
                     log.debug(String.format("No IDP found with resource ID: %s either in cache or DB", resourceId));
@@ -804,30 +804,6 @@ public void addIdPCache(IdentityProvider identityProvider, String tenantDomain)
         }
     }
 
-    /**
-     * Add new cache entries for IDP against cache keys: name, home-realm-id and resource-id.
-     *
-     * @param identityProvider  Identity Provider information.
-     * @param tenantDomain      Tenant domain of IDP.
-     */
-    public void addIdPCacheOnRead(IdentityProvider identityProvider, String tenantDomain) {
-
-        if (identityProvider != null) {
-            if (log.isDebugEnabled()) {
-                log.debug("Adding new entry for Identity Provider: '" + identityProvider.getIdentityProviderName() +
-                        "' to cache.");
-            }
-            IdPNameCacheKey idPNameCacheKey = new IdPNameCacheKey(identityProvider.getIdentityProviderName());
-            idPCacheByName.addToCacheOnRead(idPNameCacheKey, new IdPCacheEntry(identityProvider), tenantDomain);
-            if (identityProvider.getHomeRealmId() != null) {
-                IdPHomeRealmIdCacheKey idPHomeRealmIdCacheKey = new IdPHomeRealmIdCacheKey(
-                        identityProvider.getHomeRealmId());
-                idPCacheByHRI.addToCacheOnRead(idPHomeRealmIdCacheKey, new IdPCacheEntry(identityProvider), tenantDomain);
-            }
-            IdPResourceIdCacheKey idPResourceIdCacheKey = new IdPResourceIdCacheKey(identityProvider.getResourceId());
-            idPCacheByResourceId.addToCacheOnRead(idPResourceIdCacheKey, new IdPCacheEntry(identityProvider), tenantDomain);
-        }
-    }
 
     public void clearIdpCache(String idPName, int tenantId, String tenantDomain)
             throws IdentityProviderManagementException {