Address reviewer suggestions

Zeta201 · Zeta201 · commit 37be91ba92d0 · 2026-03-20T19:57:51.000+05:30
diff --git a/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/tenant/JDBCTenantManager.java b/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/tenant/JDBCTenantManager.java
@@ -649,7 +649,7 @@ public String getDomain(int tenantId) throws UserStoreException {
             }
             tenantDomainNameValidation(tenantDomain);
             tenantDomainCache.addToCacheOnRead(tenantIdKey, new TenantDomainEntry(tenantDomain));
-            tenantIdCache.addToCache(new TenantDomainKey(tenantDomain), new TenantIdEntry(tenantId));
+            tenantIdCache.addToCacheOnRead(new TenantDomainKey(tenantDomain), new TenantIdEntry(tenantId));
         }
 
         if (tenantDomain != null) {
@@ -751,7 +751,7 @@ public int getTenantId(String tenantDomain) throws UserStoreException {
                 }
                 tenantDomainNameValidation(tenantDomain);
                 tenantIdCache.addToCacheOnRead(tenantDomainKey, new TenantIdEntry(tenantId));
-                tenantDomainCache.addToCache(new TenantIdKey(tenantId), new TenantDomainEntry(tenantDomain));
+                tenantDomainCache.addToCacheOnRead(new TenantIdKey(tenantId), new TenantDomainEntry(tenantDomain));
             }
         } catch (SQLException e) {
             DatabaseUtil.rollBack(dbConnection);

Original file line number	Diff line number	Diff line change
`@@ -649,7 +649,7 @@ public String getDomain(int tenantId) throws UserStoreException {`
`649`	`649`	`}`
`650`	`650`	`tenantDomainNameValidation(tenantDomain);`
`651`	`651`	`tenantDomainCache.addToCacheOnRead(tenantIdKey, new TenantDomainEntry(tenantDomain));`
`652`		`- tenantIdCache.addToCache(new TenantDomainKey(tenantDomain), new TenantIdEntry(tenantId));`
	`652`	`+ tenantIdCache.addToCacheOnRead(new TenantDomainKey(tenantDomain), new TenantIdEntry(tenantId));`
`653`	`653`	`}`
`654`	`654`
`655`	`655`	`if (tenantDomain != null) {`
`@@ -751,7 +751,7 @@ public int getTenantId(String tenantDomain) throws UserStoreException {`
`751`	`751`	`}`
`752`	`752`	`tenantDomainNameValidation(tenantDomain);`
`753`	`753`	`tenantIdCache.addToCacheOnRead(tenantDomainKey, new TenantIdEntry(tenantId));`
`754`		`- tenantDomainCache.addToCache(new TenantIdKey(tenantId), new TenantDomainEntry(tenantDomain));`
	`754`	`+ tenantDomainCache.addToCacheOnRead(new TenantIdKey(tenantId), new TenantDomainEntry(tenantDomain));`
`755`	`755`	`}`
`756`	`756`	`} catch (SQLException e) {`
`757`	`757`	`DatabaseUtil.rollBack(dbConnection);`