Skip to content

Commit cb33cba

Browse files
Merge pull request #4438 from PasinduYeshan/fix/selective-claim3
Remove claim retrieval skip logic from recursive methods.
2 parents dc7ae9d + 3f21018 commit cb33cba

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/common/AbstractUserStoreManager.java

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3267,19 +3267,6 @@ private List<String> doGetUserList(String claim, String claimValue, String profi
32673267
// For all the user stores append the domain name to the claim and pass it recursively (Including PRIMARY).
32683268
String domainName = ((AbstractUserStoreManager) userStoreManager).getMyDomainName();
32693269

3270-
try {
3271-
if (isIdentityStoreManagedClaim(claimManager.getClaim(claim), domainName, userStoreManager)) {
3272-
if (log.isDebugEnabled()) {
3273-
log.debug("The claim: " + claim + " is an identity store managed claim for the domain: "
3274-
+ domainName + ". Hence skipping the user store.");
3275-
}
3276-
continue;
3277-
}
3278-
} catch (org.wso2.carbon.user.api.UserStoreException e) {
3279-
log.error(String.format("Error occurred while retrieving claim for claim URI: %s for domain: %s.",
3280-
claim, domainName), e);
3281-
}
3282-
32833270
String claimValueWithDomain;
32843271
if (StringUtils.equalsIgnoreCase(domainName, UserCoreConstants.PRIMARY_DEFAULT_DOMAIN_NAME)) {
32853272
claimValueWithDomain = domainName + CarbonConstants.DOMAIN_SEPARATOR + claimValue;
@@ -3543,19 +3530,6 @@ private List<User> doGetUserListWithID(String claim, String claimValue, String p
35433530
// For all the user stores append the domain name to the claim and pass it recursively (Including PRIMARY).
35443531
String domainName = ((AbstractUserStoreManager) userStoreManager).getMyDomainName();
35453532

3546-
try {
3547-
if (isIdentityStoreManagedClaim(claimManager.getClaim(claim), domainName, userStoreManager)) {
3548-
if (log.isDebugEnabled()) {
3549-
log.debug("The claim: " + claim + " is an identity store managed claim for the domain: "
3550-
+ domainName + ". Hence skipping the user store.");
3551-
}
3552-
continue;
3553-
}
3554-
} catch (org.wso2.carbon.user.api.UserStoreException e) {
3555-
log.error(String.format("Error occurred while retrieving claim for claim URI: %s for domain: %s.",
3556-
claim, domainName), e);
3557-
}
3558-
35593533
String claimValueWithDomain;
35603534
if (StringUtils.equalsIgnoreCase(domainName, UserCoreConstants.PRIMARY_DEFAULT_DOMAIN_NAME)) {
35613535
claimValueWithDomain = domainName + CarbonConstants.DOMAIN_SEPARATOR + claimValue;

0 commit comments

Comments
 (0)