Allow absolute paths for skill dirs

Author: MaryamZi

ballerina-interpreter/skills.bal

@@ -44,17 +44,11 @@ type SkillFrontmatter record {
 
 function discoverSkills(SkillSource[] sources, string afmFileDir) returns map<SkillInfo>|error {
     map<SkillInfo> skills = {};
-    string normalizedAfmDir = check file:normalizePath(check file:getAbsolutePath(afmFileDir), file:CLEAN);
 
     foreach SkillSource 'source in sources {
-        if check file:isAbsolutePath('source.path) {
-            return error(string `Skill source path must be relative, but got: ${'source.path}`);
-        }
-        string resolvedPath = check file:joinPath(afmFileDir, 'source.path);
-        string normalizedPath = check file:normalizePath(check file:getAbsolutePath(resolvedPath), file:CLEAN);
-        if normalizedPath != normalizedAfmDir && !normalizedPath.startsWith(normalizedAfmDir + file:pathSeparator) {
-            return error(string `Skill source path '${'source.path}' resolves outside the AFM file directory`);
-        }
+        string resolvedPath = check file:isAbsolutePath('source.path)
+            ? 'source.path
+            : check file:joinPath(afmFileDir, 'source.path);
         map<SkillInfo> localSkills = check discoverLocalSkills(resolvedPath);
         foreach [string, SkillInfo] [name, info] in localSkills.entries() {
             if skills.hasKey(name) {

ballerina-interpreter/tests/skills_test.bal

@@ -325,41 +325,12 @@ function testDiscoverLocalSkillsInvalidSkill() returns error? {
 }
 
 @test:Config
-function testDiscoverSkillsAbsolutePathRejected() returns error? {
-    string testDir = check file:getAbsolutePath("tests/skills");
-    SkillSource[] sources = [{path: "/absolute/path/to/skills"}];
-    map<SkillInfo>|error result = discoverSkills(sources, testDir);
-    if result is map<SkillInfo> {
-        test:assertFail("Expected error for absolute path");
-    }
-    test:assertTrue(result.message().includes("must be relative"));
-}
-
-@test:Config
-function testDiscoverSkillsPathOutsideAfmDirRejected() returns error? {
-    string testDir = check file:getAbsolutePath("tests/skills");
-    SkillSource[] sources = [{path: "../../outside"}];
-    map<SkillInfo>|error result = discoverSkills(sources, testDir);
-    if result is map<SkillInfo> {
-        test:assertFail("Expected error for path outside AFM directory");
-    }
-    test:assertTrue(result.message().includes("resolves outside"));
-}
-
-@test:Config
-function testDiscoverSkillsSiblingPrefixPathRejected() returns error? {
-    // A sibling directory sharing a name prefix must not pass validation.
-    // E.g. if afm_dir is '/a/skills', a path resolving to '/a/skills-evil'
-    // should be rejected even though it starts with the same string prefix.
-    string testDir = check file:getAbsolutePath("tests/skills/single_skill");
-    // "../single_skill_extra" would resolve to tests/skills/single_skill_extra
-    // which shares the prefix "tests/skills/single_skill" but is outside the dir
-    SkillSource[] sources = [{path: "../single_skill_extra"}];
-    map<SkillInfo>|error result = discoverSkills(sources, testDir);
-    if result is map<SkillInfo> {
-        test:assertFail("Expected error for sibling prefix path");
-    }
-    test:assertTrue(result.message().includes("resolves outside"));
+function testDiscoverSkillsAbsolutePathAccepted() returns error? {
+    string absPath = check file:getAbsolutePath("tests/skills/single_skill");
+    SkillSource[] sources = [{path: absPath}];
+    map<SkillInfo> skills = check discoverSkills(sources, "some/other/dir");
+    test:assertEquals(skills.length(), 1);
+    test:assertTrue(skills.hasKey("test-gen"));
 }
 
 @test:Config