minor

Author: dprzybyl

app/aem/core/src/main/java/com/cognifide/apm/checks/actions/permissions/CheckPermissions.java

@@ -34,11 +34,11 @@
 import java.util.List;
 import java.util.Set;
 import java.util.regex.Pattern;
-import java.util.stream.Collectors;
 import javax.jcr.Node;
 import javax.jcr.NodeIterator;
 import javax.jcr.RepositoryException;
 import javax.jcr.Session;
+import org.apache.commons.collections4.ListUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.jackrabbit.api.security.principal.PrincipalIterator;
 import org.apache.jackrabbit.api.security.user.Authorizable;
@@ -172,6 +172,6 @@ private static Set<Principal> getAuthorizablesToCheck(Authorizable authorizable,
   }
 
   private List<String> preparePrivilegesToCheck() {
-    return permissions.stream().map(String::toLowerCase).collect(Collectors.toList());
+    return ListUtils.transformedList(permissions, String::toLowerCase);
   }
 }

app/aem/core/src/main/java/com/cognifide/apm/core/logger/ProgressEntry.java

@@ -21,8 +21,8 @@
 
 import com.cognifide.apm.api.services.ExecutionResult.Entry;
 import com.cognifide.apm.api.status.Status;
-import java.util.Collections;
 import java.util.List;
+import org.apache.commons.collections4.ListUtils;
 import org.apache.commons.lang3.StringUtils;
 
 public class ProgressEntry implements Entry {
@@ -44,8 +44,8 @@ public ProgressEntry(Status status, List<String> messages, String command, Strin
     this.status = status != null ? status : Status.SUCCESS;
     this.command = StringUtils.defaultString(command);
     this.position = position;
-    this.messages = messages != null ? Collections.unmodifiableList(messages) : Collections.emptyList();
-    this.parameters = parameters != null ? Collections.unmodifiableList(parameters) : Collections.emptyList();
+    this.messages = ListUtils.emptyIfNull(messages);
+    this.parameters = ListUtils.emptyIfNull(parameters);
     this.authorizable = StringUtils.defaultString(authorizable);
   }
 

app/aem/core/src/main/java/com/cognifide/apm/core/services/async/AsyncScriptExecutorImpl.java

@@ -27,7 +27,6 @@
 import com.cognifide.apm.core.jobs.JobResultsCache.ExecutionSummary;
 import com.cognifide.apm.core.jobs.ScriptRunnerJobConsumer;
 import java.util.Calendar;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -69,7 +68,7 @@ public String process(Script script, ExecutionMode executionMode, Map<String, St
     properties.put(USER_ID, executor);
     properties.put(DEFINITIONS, customDefinitions);
     jobResultsCache.put(id, ExecutionSummary.running());
-    new Thread(() -> scriptRunnerJobConsumer.process(Collections.unmodifiableMap(properties))).start();
+    new Thread(() -> scriptRunnerJobConsumer.process(properties)).start();
     return id;
   }