Skip to content

Commit b708388

Browse files
committed
Merge branch 'master' into add-data-source-support
2 parents 3596774 + 2611bb3 commit b708388

File tree

25 files changed

+107
-22
lines changed

25 files changed

+107
-22
lines changed

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/addchildren/AddChildren.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ private ActionResult process(Context context, boolean execute) {
6666
LOGGER.info("Adding authorizables {} to group with id={}", String.join(", ", authorizableIds), group.getID());
6767
} catch (RepositoryException | ActionExecutionException e) {
6868
actionResult.logError(MessagingUtils.createMessage(e));
69+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
6970
return actionResult;
7071
}
7172

@@ -101,7 +102,7 @@ private ActionResult process(Context context, boolean execute) {
101102
}
102103

103104
if (actionResult.getStatus() == Status.ERROR) {
104-
actionResult.logError("Execution interrupted");
105+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
105106
}
106107
return actionResult;
107108
}

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/addparents/AddParents.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ private ActionResult process(Context context, boolean execute) {
6565
actionResult.setAuthorizable(authorizable.getID());
6666
} catch (RepositoryException | ActionExecutionException e) {
6767
actionResult.logError(MessagingUtils.createMessage(e));
68+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
6869
return actionResult;
6970
}
7071

@@ -101,7 +102,7 @@ private ActionResult process(Context context, boolean execute) {
101102
}
102103

103104
if (actionResult.getStatus() == Status.ERROR) {
104-
actionResult.logError("Execution interrupted");
105+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
105106
}
106107
return actionResult;
107108
}

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/allow/Allow.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.cognifide.apm.main.permissions.PermissionActionHelper;
2828
import com.cognifide.apm.main.permissions.Restrictions;
2929
import com.cognifide.apm.main.permissions.exceptions.PermissionException;
30+
import com.cognifide.apm.main.utils.ActionUtils;
3031
import com.cognifide.apm.main.utils.MessagingUtils;
3132
import com.cognifide.apm.main.utils.PathUtils;
3233
import java.util.Collections;
@@ -103,11 +104,14 @@ private ActionResult process(Context context, boolean simulate) {
103104
actionResult.logWarning("Path " + path + " not found");
104105
} else {
105106
actionResult.logError("Path " + path + " not found");
106-
return actionResult;
107107
}
108108
} catch (RepositoryException | PermissionException | ActionExecutionException e) {
109109
actionResult.logError(MessagingUtils.createMessage(e));
110110
}
111+
112+
if (actionResult.getStatus() == Status.ERROR) {
113+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
114+
}
111115
return actionResult;
112116
}
113117

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/clearpermissions/Purge.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.cognifide.apm.api.actions.Message;
2626
import com.cognifide.apm.api.exceptions.ActionExecutionException;
2727
import com.cognifide.apm.api.status.Status;
28+
import com.cognifide.apm.main.utils.ActionUtils;
2829
import com.cognifide.apm.main.utils.MessagingUtils;
2930
import com.cognifide.apm.main.utils.PathUtils;
3031
import java.util.HashSet;
@@ -87,6 +88,9 @@ private ActionResult process(Context context, boolean execute) {
8788
actionResult.logError(MessagingUtils.createMessage(e));
8889
}
8990

91+
if (actionResult.getStatus() == Status.ERROR) {
92+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
93+
}
9094
return actionResult;
9195
}
9296

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/clearpermissions/RemoveAll.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.cognifide.apm.api.exceptions.ActionExecutionException;
2626
import com.cognifide.apm.api.status.Status;
2727
import com.cognifide.apm.main.permissions.utils.JackrabbitAccessControlListUtil;
28+
import com.cognifide.apm.main.utils.ActionUtils;
2829
import com.cognifide.apm.main.utils.MessagingUtils;
2930
import com.cognifide.apm.main.utils.PathUtils;
3031
import java.security.Principal;
@@ -73,6 +74,10 @@ private ActionResult process(final Context context, boolean execute) {
7374
} catch (RepositoryException | ActionExecutionException e) {
7475
actionResult.logError(MessagingUtils.createMessage(e));
7576
}
77+
78+
if (actionResult.getStatus() == Status.ERROR) {
79+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
80+
}
7681
return actionResult;
7782
}
7883

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/createauthorizable/CreateAuthorizable.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.cognifide.apm.api.actions.Context;
2525
import com.cognifide.apm.api.status.Status;
2626
import com.cognifide.apm.main.actions.forauthorizable.ForAuthorizable;
27+
import com.cognifide.apm.main.utils.ActionUtils;
2728
import com.cognifide.apm.main.utils.MessagingUtils;
2829
import javax.jcr.RepositoryException;
2930
import org.apache.jackrabbit.api.security.user.Authorizable;
@@ -83,6 +84,8 @@ public ActionResult process(Context context, boolean simulate) {
8384
if (actionResult.getStatus() != Status.ERROR) {
8485
ActionResult forAuthorizableActionResult = new ForAuthorizable(id, false, createStrategy == CreateAuthorizableStrategy.GROUP).process(context);
8586
actionResult.changeStatus(forAuthorizableActionResult.getStatus(), forAuthorizableActionResult.getMessages().get(0).getText());
87+
} else {
88+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
8689
}
8790
return actionResult;
8891
}

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/deletegroup/DeleteGroup.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.cognifide.apm.api.exceptions.ActionExecutionException;
2626
import com.cognifide.apm.api.exceptions.AuthorizableNotFoundException;
2727
import com.cognifide.apm.api.status.Status;
28+
import com.cognifide.apm.main.utils.ActionUtils;
2829
import com.cognifide.apm.main.utils.MessagingUtils;
2930
import java.util.List;
3031
import javax.jcr.RepositoryException;
@@ -72,7 +73,7 @@ private ActionResult process(Context context, boolean execute) {
7273
}
7374

7475
if (actionResult.getStatus() == Status.ERROR) {
75-
actionResult.logError("Execution interrupted");
76+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
7677
}
7778
return actionResult;
7879
}

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/deleteuser/DestroyUser.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,10 @@
2424
import com.cognifide.apm.api.actions.Context;
2525
import com.cognifide.apm.api.exceptions.ActionExecutionException;
2626
import com.cognifide.apm.api.exceptions.AuthorizableNotFoundException;
27+
import com.cognifide.apm.api.status.Status;
2728
import com.cognifide.apm.main.actions.clearpermissions.Purge;
2829
import com.cognifide.apm.main.actions.removeparents.RemoveParents;
30+
import com.cognifide.apm.main.utils.ActionUtils;
2931
import com.cognifide.apm.main.utils.MessagingUtils;
3032
import java.util.ArrayList;
3133
import java.util.Collections;
@@ -67,6 +69,10 @@ public ActionResult simulate(Context context) {
6769
actionResult = context.createActionResult();
6870
actionResult.logWarning(MessagingUtils.createMessage(e));
6971
}
72+
73+
if (actionResult.getStatus() == Status.ERROR) {
74+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
75+
}
7076
return actionResult;
7177
}
7278

@@ -91,6 +97,10 @@ public ActionResult execute(Context context) {
9197
actionResult = context.createActionResult();
9298
actionResult.logWarning(MessagingUtils.createMessage(e));
9399
}
100+
101+
if (actionResult.getStatus() == Status.ERROR) {
102+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
103+
}
94104
return actionResult;
95105
}
96106

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/deleteuser/RemoveUser.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.cognifide.apm.api.exceptions.ActionExecutionException;
2626
import com.cognifide.apm.api.exceptions.AuthorizableNotFoundException;
2727
import com.cognifide.apm.api.status.Status;
28+
import com.cognifide.apm.main.utils.ActionUtils;
2829
import com.cognifide.apm.main.utils.MessagingUtils;
2930
import java.util.List;
3031
import javax.jcr.RepositoryException;
@@ -71,7 +72,7 @@ private ActionResult process(Context context, boolean execute) {
7172
}
7273

7374
if (actionResult.getStatus() == Status.ERROR) {
74-
actionResult.logError("Execution interrupted");
75+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
7576
}
7677
return actionResult;
7778
}

app/aem/actions.main/src/main/java/com/cognifide/apm/main/actions/deny/Deny.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.cognifide.apm.main.permissions.PermissionActionHelper;
2828
import com.cognifide.apm.main.permissions.Restrictions;
2929
import com.cognifide.apm.main.permissions.exceptions.PermissionException;
30+
import com.cognifide.apm.main.utils.ActionUtils;
3031
import com.cognifide.apm.main.utils.MessagingUtils;
3132
import com.cognifide.apm.main.utils.PathUtils;
3233
import java.util.ArrayList;
@@ -108,6 +109,10 @@ private ActionResult process(Context context, boolean simulate) {
108109
} catch (RepositoryException | PermissionException | ActionExecutionException e) {
109110
actionResult.logError(MessagingUtils.createMessage(e));
110111
}
112+
113+
if (actionResult.getStatus() == Status.ERROR) {
114+
actionResult.logError(ActionUtils.EXECUTION_INTERRUPTED_MSG);
115+
}
111116
return actionResult;
112117
}
113118

0 commit comments

Comments
 (0)