Notification bug fix

Author: krystian-panek-vmltech

core/src/main/java/dev/vml/es/acm/core/code/Executor.java

@@ -252,10 +252,17 @@ private void handleNotifications(ExecutionContext context, ImmediateExecution ex
         fields.put("Instance", instanceDesc);
 
         int detailsMaxLength = config.notificationDetailsLength();
-        String output = StringUtil.markdownCode(execution.getOutput(), "(none)");
-        String error = StringUtil.markdownCode(execution.getError(), "(none)");
-        fields.put("Output", detailsMaxLength < 0 ? output : StringUtil.abbreviateStart(output, detailsMaxLength, "[...] "));
-        fields.put("Error", detailsMaxLength < 0 ? error : StringUtils.abbreviate(error, detailsMaxLength));
+        String output = StringUtils.trimToNull(execution.getOutput());
+        String error = StringUtils.trimToNull(execution.getError());
+        fields.put(
+                "Output",
+                StringUtil.markdownCode(
+                        detailsMaxLength < 0 ? output : StringUtil.abbreviateStart(output, detailsMaxLength, "(...)"),
+                        "(none)"));
+        fields.put(
+                "Error",
+                StringUtil.markdownCode(
+                        detailsMaxLength < 0 ? error : StringUtils.abbreviate(error, detailsMaxLength), "(none)"));
 
         notifier.sendMessageTo(config.notificationNotifierId(), title, text, fields);
     }

core/src/main/java/dev/vml/es/acm/core/notification/slack/Slack.java

@@ -4,7 +4,6 @@
 import dev.vml.es.acm.core.util.JsonUtils;
 import java.io.IOException;
 import java.util.Map;
-
 import org.apache.commons.lang3.ArrayUtils;
 import org.apache.http.HttpHeaders;
 import org.apache.http.client.config.RequestConfig;
@@ -59,7 +58,8 @@ public boolean isEnabled() {
 
     @Override
     public void sendMessage(String title, String text, Map<String, Object> fields) {
-        SlackPayload payload = SlackPayload.builder().message(title, text, fields).build();
+        SlackPayload payload =
+                SlackPayload.builder().message(title, text, fields).build();
         sendPayload(payload);
     }
 

core/src/main/java/dev/vml/es/acm/core/notification/teams/Teams.java

@@ -4,7 +4,6 @@
 import dev.vml.es.acm.core.util.JsonUtils;
 import java.io.IOException;
 import java.util.Map;
-
 import org.apache.commons.lang3.ArrayUtils;
 import org.apache.http.HttpHeaders;
 import org.apache.http.client.config.RequestConfig;
@@ -59,7 +58,8 @@ public boolean isEnabled() {
 
     @Override
     public void sendMessage(String title, String text, Map<String, Object> fields) {
-        TeamsPayload payload = TeamsPayload.builder().message(title, text, fields).build();
+        TeamsPayload payload =
+                TeamsPayload.builder().message(title, text, fields).build();
         sendPayload(payload);
     }
 

core/src/main/java/dev/vml/es/acm/core/util/StringUtil.java

@@ -62,9 +62,9 @@ public static String formatDuration(long millis) {
         }
     }
 
-    public static String markdownCode(String code, String defaulString) {
+    public static String markdownCode(String code, String defaultString) {
         if (StringUtils.isBlank(code)) {
-            return defaulString;
+            return defaultString;
         }
         return "```\n" + code.trim() + "\n```";
     }