Merge pull request #10 from Cognifide/fix-env-hosts-on-mac-when-project-in-documents-folder

#8 fix env hosts on Mac when project is in Documents folder

Author: Krystian Panek

src/main/kotlin/com/cognifide/gradle/environment/hosts/HostUpdater.kt

@@ -1,7 +1,9 @@
 package com.cognifide.gradle.environment.hosts
 
+import com.cognifide.gradle.environment.EnvironmentException
 import com.cognifide.gradle.environment.EnvironmentExtension
 import org.gradle.internal.os.OperatingSystem
+import java.io.ByteArrayOutputStream
 
 class HostUpdater(val environment: EnvironmentExtension) {
 
@@ -50,8 +52,8 @@ class HostUpdater(val environment: EnvironmentExtension) {
         val updaterJar = dir.resolve("hosts.jar").apply {
             logger.info("Providing hosts updater program: $this")
             outputStream().use { output ->
-                this@HostUpdater.javaClass.getResourceAsStream("/hosts.jar").use {
-                    input -> input.copyTo(output)
+                this@HostUpdater.javaClass.getResourceAsStream("/hosts.jar").use { input ->
+                    input.copyTo(output)
                 }
             }
         }
@@ -64,26 +66,57 @@ class HostUpdater(val environment: EnvironmentExtension) {
             scriptFile.writeText("""
                 powershell -command "Start-Process cmd -ArgumentList '/C cd %CD% && java -jar $updaterJar $sectionName $entriesFile $osFile' -Verb runas"
             """.trimIndent())
-            project.exec { it.commandLine("cmd", "/C", scriptFile.toString()) }
-            logger.lifecycle("Environment hosts successfully updated.")
-        } else {
-            val scriptFile = dir.resolve("hosts.sh")
-            logger.info("Generating hosts updating script: $scriptFile")
+            execAndHandleErrors(listOf("cmd", "/C", scriptFile.toString()))
+            return
+        }
+
+        val scriptFile = dir.resolve("hosts.sh")
+        logger.info("Generating hosts updating script: $scriptFile")
 
-            if (os.isMacOsX && interactive.get()) {
-                scriptFile.writeText("""
+        if (os.isMacOsX && interactive.get()) {
+            scriptFile.writeText("""
                     #!/bin/sh
                     osascript -e "do shell script \"java -jar $updaterJar $sectionName $entriesFile $osFile\" with prompt \"Gradle Environment Hosts\" with administrator privileges" 
                 """.trimIndent())
-                project.exec { it.commandLine("sh", scriptFile.toString()) }
-                logger.lifecycle("Environment hosts successfully updated.")
-            } else {
-                scriptFile.writeText("""
+            execOnMacAndHandleErrors(listOf("sh", scriptFile.toString()))
+            return
+        }
+
+        scriptFile.writeText("""
                     #!/bin/sh
                     java -jar $updaterJar $sectionName $entriesFile $osFile
                 """.trimIndent())
-                logger.lifecycle("To update environment hosts, run script below as administrator/super-user:\n$scriptFile")
+        logger.lifecycle("To update environment hosts, run script below as administrator/super-user:\n$scriptFile")
+    }
+
+    private fun execOnMacAndHandleErrors(commandLine: List<String>) = execAndHandleErrors(commandLine) { errorText ->
+        if (errorText.contains("Unable to access jarfile")) {
+            mutableListOf<String>().apply {
+                add("Failed to update environment hosts. Unable to access executable. Probably project source files are placed under")
+                add("the 'Documents', 'Desktop' or 'Downloads' directory. This may cause errors related to accessing files in the future.")
+
+                add("Consider troubleshooting:")
+                add("* move project files outside of 'Documents', 'Desktop' or 'Downloads' directories to avoid problems")
+                add("* or set the host updater work directory to a path directly under your files home in your gradle.properties file as a workaround:")
+                add("    * environment.hosts.updater.workDir=${System.getProperty("user.home")}/.gap/hosts")
+
+                logger.error(joinToString("\n"))
             }
         }
+        throw EnvironmentException(errorText)
+    }
+
+    private fun execAndHandleErrors(commandLine: List<String>, errorHandler: (String) -> Unit = { throw EnvironmentException(it) }) {
+        val errorOutput = ByteArrayOutputStream()
+        val execResult = project.exec {
+            it.errorOutput = errorOutput
+            it.isIgnoreExitValue = true
+            it.commandLine(commandLine)
+        }
+        if (execResult.exitValue == 0) {
+            logger.lifecycle("Environment hosts successfully updated.")
+            return
+        }
+        errorHandler(errorOutput.toString("UTF8"))
     }
 }