ext/ldap: php_ldap_do_modify() throw ValueError when entries array is empty

Author: Girgias

ext/ldap/ldap.c

@@ -2216,6 +2216,11 @@ static void php_ldap_do_modify(INTERNAL_FUNCTION_PARAMETERS, int oper, int ext)
 	VERIFY_LDAP_LINK_CONNECTED(ld);
 
 	num_attribs = zend_hash_num_elements(Z_ARRVAL_P(entry));
+	if (num_attribs == 0) {
+		zend_argument_must_not_be_empty_error(3);
+		RETURN_THROWS();
+	}
+
 	ldap_mods = safe_emalloc((num_attribs+1), sizeof(LDAPMod *), 0);
 	num_berval = safe_emalloc(num_attribs, sizeof(int), 0);
 	zend_hash_internal_pointer_reset(Z_ARRVAL_P(entry));

ext/ldap/tests/ldap_add_modify_delete_programming_errors.phpt

@@ -132,8 +132,7 @@ try {
 
 ?>
 --EXPECTF--
-Warning: ldap_add(): Add: Can't contact LDAP server in %s on line %d
-bool(false)
+ValueError: ldap_add(): Argument #3 ($entry) must not be empty
 
 Warning: ldap_add(): Unknown attribute in the data in %s on line %d
 bool(false)