curl: Remove incorrect string release on error

ndossche · ndossche · commit 11ea995ff396 · 2025-07-02T18:42:50.000+02:00
The string is owned by the caller, and the caller releases it. Closes phpGH-18989.
diff --git a/NEWS b/NEWS
@@ -13,6 +13,7 @@ PHP                                                                        NEWS
 - Curl:
   . Fix memory leaks when returning refcounted value from curl callback.
     (nielsdos)
+  . Remove incorrect string release. (nielsdos)
 
 - LDAP:
   . Fixed GH-18902 ldap_exop/ldap_exop_sync assert triggered on empty
diff --git a/ext/curl/interface.c b/ext/curl/interface.c
@@ -1369,7 +1369,6 @@ static inline CURLcode add_simple_field(struct HttpPost **first, struct HttpPost
 	part = curl_mime_addpart(mime);
 	if (part == NULL) {
 		zend_tmp_string_release(tmp_postval);
-		zend_string_release_ex(string_key, 0);
 		return CURLE_OUT_OF_MEMORY;
 	}
 	if ((form_error = curl_mime_name(part, ZSTR_VAL(string_key))) != CURLE_OK

Original file line number	Diff line number	Diff line change
`@@ -1369,7 +1369,6 @@ static inline CURLcode add_simple_field(struct HttpPost **first, struct HttpPost`
`1369`	`1369`	`part = curl_mime_addpart(mime);`
`1370`	`1370`	`if (part == NULL) {`
`1371`	`1371`	`zend_tmp_string_release(tmp_postval);`
`1372`		`- zend_string_release_ex(string_key, 0);`
`1373`	`1372`	`return CURLE_OUT_OF_MEMORY;`
`1374`	`1373`	`}`
`1375`	`1374`	`if ((form_error = curl_mime_name(part, ZSTR_VAL(string_key))) != CURLE_OK`