sqlite3: remove nonsensical return_value dtor (php#20360)

ndossche · web-flow · commit 197a455bc02e · 2025-11-02T23:47:10.000+01:00
diff --git a/ext/sqlite3/sqlite3.c b/ext/sqlite3/sqlite3.c
@@ -1916,7 +1916,6 @@ PHP_METHOD(SQLite3Stmt, __construct)
 	errcode = sqlite3_prepare_v2(db_obj->db, ZSTR_VAL(sql), ZSTR_LEN(sql), &(stmt_obj->stmt), NULL);
 	if (errcode != SQLITE_OK) {
 		php_sqlite3_error(db_obj, errcode, "Unable to prepare statement: %s", sqlite3_errmsg(db_obj->db));
-		zval_ptr_dtor(return_value);
 		RETURN_FALSE;
 	}
 	stmt_obj->initialised = true;

Original file line number	Diff line number	Diff line change
`@@ -1916,7 +1916,6 @@ PHP_METHOD(SQLite3Stmt, __construct)`
`1916`	`1916`	`errcode = sqlite3_prepare_v2(db_obj->db, ZSTR_VAL(sql), ZSTR_LEN(sql), &(stmt_obj->stmt), NULL);`
`1917`	`1917`	`if (errcode != SQLITE_OK) {`
`1918`	`1918`	`php_sqlite3_error(db_obj, errcode, "Unable to prepare statement: %s", sqlite3_errmsg(db_obj->db));`
`1919`		`- zval_ptr_dtor(return_value);`
`1920`	`1919`	`RETURN_FALSE;`
`1921`	`1920`	`}`
`1922`	`1921`	`stmt_obj->initialised = true;`