Skip to content

Commit b3d8465

Browse files
committed
Merge branch 'PHP-8.5'
* PHP-8.5: Fix phpGH-19798: XP_SOCKET XP_SSL: Incorrect condition for Win
2 parents 025e16c + 4545174 commit b3d8465

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

ext/openssl/xp_ssl.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2219,7 +2219,6 @@ static int php_openssl_sockop_stat(php_stream *stream, php_stream_statbuf *ssb)
22192219
static inline int php_openssl_tcp_sockop_accept(php_stream *stream, php_openssl_netstream_data_t *sock,
22202220
php_stream_xport_param *xparam STREAMS_DC) /* {{{ */
22212221
{
2222-
int clisock;
22232222
bool nodelay = false;
22242223
zval *tmpzval = NULL;
22252224

@@ -2231,7 +2230,7 @@ static inline int php_openssl_tcp_sockop_accept(php_stream *stream, php_openssl_
22312230
nodelay = true;
22322231
}
22332232

2234-
clisock = php_network_accept_incoming(sock->s.socket,
2233+
php_socket_t clisock = php_network_accept_incoming(sock->s.socket,
22352234
xparam->want_textaddr ? &xparam->outputs.textaddr : NULL,
22362235
xparam->want_addr ? &xparam->outputs.addr : NULL,
22372236
xparam->want_addr ? &xparam->outputs.addrlen : NULL,
@@ -2240,7 +2239,7 @@ static inline int php_openssl_tcp_sockop_accept(php_stream *stream, php_openssl_
22402239
&xparam->outputs.error_code,
22412240
nodelay);
22422241

2243-
if (clisock >= 0) {
2242+
if (clisock != SOCK_ERR) {
22442243
php_openssl_netstream_data_t *clisockdata = (php_openssl_netstream_data_t*) emalloc(sizeof(*clisockdata));
22452244

22462245
/* copy underlying tcp fields */

main/streams/xp_socket.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,7 @@ static inline int php_tcp_sockop_accept(php_stream *stream, php_netstream_data_t
878878
&xparam->outputs.error_code,
879879
nodelay);
880880

881-
if (clisock >= 0) {
881+
if (clisock != SOCK_ERR) {
882882
php_netstream_data_t *clisockdata = (php_netstream_data_t*) emalloc(sizeof(*clisockdata));
883883

884884
memcpy(clisockdata, sock, sizeof(*clisockdata));

0 commit comments

Comments
 (0)