ext/session: Minor code cleanups

Girgias · Girgias · commit c3dac0f8b6c0 · 2025-07-06T17:21:00.000+01:00
diff --git a/ext/session/session.c b/ext/session/session.c
@@ -1162,7 +1162,7 @@ static const ps_module *ps_modules[MAX_MODULES + 1] = {
 
 PHPAPI zend_result php_session_register_module(const ps_module *ptr)
 {
-	int ret = FAILURE;
+	zend_result ret = FAILURE;
 
 	for (int i = 0; i < MAX_MODULES; i++) {
 		if (!ps_modules[i]) {
@@ -1211,7 +1211,7 @@ static const char *week_days[] = {
 	"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"
 };
 
-static inline void strcpy_gmt(char *ubuf, time_t *when)
+static inline void strcpy_gmt(char *ubuf, const time_t *when)
 {
 	char buf[MAX_STR];
 	struct tm tm, *res;
@@ -3056,7 +3056,7 @@ static bool php_check_cancel_upload(php_session_rfc1867_progress *progress)
 	return Z_TYPE_P(cancel_upload) == IS_TRUE;
 }
 
-static void php_session_rfc1867_update(php_session_rfc1867_progress *progress, int force_update)
+static void php_session_rfc1867_update(php_session_rfc1867_progress *progress, bool force_update)
 {
 	if (!force_update) {
 		if (Z_LVAL_P(progress->post_bytes_processed) < progress->next_update) {

Original file line number	Diff line number	Diff line change
`@@ -1162,7 +1162,7 @@ static const ps_module *ps_modules[MAX_MODULES + 1] = {`
`1162`	`1162`
`1163`	`1163`	`PHPAPI zend_result php_session_register_module(const ps_module *ptr)`
`1164`	`1164`	`{`
`1165`		`- int ret = FAILURE;`
	`1165`	`+ zend_result ret = FAILURE;`
`1166`	`1166`
`1167`	`1167`	`for (int i = 0; i < MAX_MODULES; i++) {`
`1168`	`1168`	`if (!ps_modules[i]) {`
`@@ -1211,7 +1211,7 @@ static const char *week_days[] = {`
`1211`	`1211`	`"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"`
`1212`	`1212`	`};`
`1213`	`1213`
`1214`		`-static inline void strcpy_gmt(char ubuf, time_t when)`
	`1214`	`+static inline void strcpy_gmt(char ubuf, const time_t when)`
`1215`	`1215`	`{`
`1216`	`1216`	`char buf[MAX_STR];`
`1217`	`1217`	`struct tm tm, *res;`
`@@ -3056,7 +3056,7 @@ static bool php_check_cancel_upload(php_session_rfc1867_progress *progress)`
`3056`	`3056`	`return Z_TYPE_P(cancel_upload) == IS_TRUE;`
`3057`	`3057`	`}`
`3058`	`3058`
`3059`		`-static void php_session_rfc1867_update(php_session_rfc1867_progress *progress, int force_update)`
	`3059`	`+static void php_session_rfc1867_update(php_session_rfc1867_progress *progress, bool force_update)`
`3060`	`3060`	`{`
`3061`	`3061`	`if (!force_update) {`
`3062`	`3062`	`if (Z_LVAL_P(progress->post_bytes_processed) < progress->next_update) {`