Skip to content

Commit cf33fd7

Browse files
committed
Fix fallback value handling in the real-time benchmark
"{{ inputs.opcache || '1' }}" doesn't work the way I used to think: I assumed it only falls back to 1 if the input is not set (when a scheduled workflow runs). So this bug is fixed by overwriting the env vars in bash in case of manual workflows.
1 parent 96990f4 commit cf33fd7

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

.github/workflows/real-time-benchmark.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ jobs:
6767
COMMIT: ${{ github.sha }}
6868
BASELINE_COMMIT: "d5f6e56610c729710073350af318c4ea1b292cfe"
6969
ID: "master"
70-
OPCACHE: ${{ inputs.opcache || '1' }}
71-
BASELINE_OPCACHE: ${{ inputs.baseline_opcache || '2' }}
72-
JIT: ${{ inputs.jit || '1' }}
73-
INSTRUCTION_COUNT: ${{ inputs.instruction_count || '1' }}
74-
RUN_MICRO_BENCH: ${{ inputs.run_micro_bench || '0' }}
70+
OPCACHE: "1"
71+
BASELINE_OPCACHE: "2"
72+
JIT: "1"
73+
INSTRUCTION_COUNT: "1"
74+
RUN_MICRO_BENCH: "0"
7575
YEAR: ""
7676
steps:
7777
- name: Setup benchmark environment
@@ -97,6 +97,12 @@ jobs:
9797
echo "BASELINE_COMMIT=$BASELINE_COMMIT" >> $GITHUB_ENV
9898
9999
echo "ID=benchmarked" >> $GITHUB_ENV
100+
101+
echo "OPCACHE=${{ inputs.opcache }}" >> $GITHUB_ENV
102+
echo "BASELINE_OPCACHE=${{ inputs.baseline_opcache }}" >> $GITHUB_ENV
103+
echo "JIT=${{ inputs.jit }}" >> $GITHUB_ENV
104+
echo "INSTRUCTION_COUNT=${{ inputs.instruction_count }}" >> $GITHUB_ENV
105+
echo "RUN_MICRO_BENCH=${{ inputs.run_micro_bench }}" >> $GITHUB_ENV
100106
fi
101107
102108
- name: Install dependencies

0 commit comments

Comments
 (0)