ext/socket: Remove incorrect zval_ptr_dtor

ndossche · ndossche · commit d11099ae325b · 2025-07-17T21:50:35.000+02:00
diff --git a/ext/sockets/sockets.c b/ext/sockets/sockets.c
@@ -2511,7 +2511,6 @@ PHP_FUNCTION(socket_addrinfo_bind)
 			}
 		default:
 			close(php_sock->bsd_socket);
-			zval_ptr_dtor(return_value);
 			zend_argument_value_error(1, "must be one of AF_UNIX, AF_INET, or AF_INET6");
 			RETURN_THROWS();
 	}
@@ -2575,7 +2574,6 @@ PHP_FUNCTION(socket_addrinfo_connect)
 		default:
 			zend_argument_value_error(1, "socket type must be one of AF_UNIX, AF_INET, or AF_INET6");
 			close(php_sock->bsd_socket);
-			zval_ptr_dtor(return_value);
 			RETURN_THROWS();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2511,7 +2511,6 @@ PHP_FUNCTION(socket_addrinfo_bind)`
`2511`	`2511`	`}`
`2512`	`2512`	`default:`
`2513`	`2513`	`close(php_sock->bsd_socket);`
`2514`		`- zval_ptr_dtor(return_value);`
`2515`	`2514`	`zend_argument_value_error(1, "must be one of AF_UNIX, AF_INET, or AF_INET6");`
`2516`	`2515`	`RETURN_THROWS();`
`2517`	`2516`	`}`
`@@ -2575,7 +2574,6 @@ PHP_FUNCTION(socket_addrinfo_connect)`
`2575`	`2574`	`default:`
`2576`	`2575`	`zend_argument_value_error(1, "socket type must be one of AF_UNIX, AF_INET, or AF_INET6");`
`2577`	`2576`	`close(php_sock->bsd_socket);`
`2578`		`- zval_ptr_dtor(return_value);`
`2579`	`2577`	`RETURN_THROWS();`
`2580`	`2578`	`}`
`2581`	`2579`