ext/pdo_pgsql: Delete unused constants

These constants were added by 6ed1819 but they are not used anymore.

They are undocumented which is why I've stumbled upon this.

close phpGH-18358

Author: vrana

NEWS

@@ -137,6 +137,7 @@ PHP                                                                        NEWS
   . Implement GH-15387 Pdo\Pgsql::setAttribute(PDO::ATTR_PREFETCH, 0) or
     Pdo\Pgsql::prepare(…, [ PDO::ATTR_PREFETCH => 0 ]) make fetch() lazy
     instead of storing the whole result set in memory (Guillaume Outters)
+  . Removed unused constants Pdo\Pgsql::TRANSACTION_*.
 
 - PDO_SQLITE:
   . throw on null bytes / resolve GH-13952 (divinity76).

UPGRADING

@@ -101,6 +101,9 @@ PHP 8.5 UPGRADE NOTES
   . A ValueError is now thrown when trying to set a cursor name that is too
     long on a PDOStatement resulting from the Firebird driver.
 
+- PDO_PGSQL:
+  . Removed unused constants Pdo\Pgsql::TRANSACTION_*.
+
 - Session:
   . Attempting to write session data where $_SESSION has a key containing
     the pipe character will now emit a warning instead of silently failing.

ext/pdo_pgsql/pdo_pgsql.c

@@ -179,11 +179,6 @@ PHP_METHOD(Pdo_Pgsql, setNoticeCallback)
 PHP_MINIT_FUNCTION(pdo_pgsql)
 {
 	REGISTER_PDO_CLASS_CONST_LONG("PGSQL_ATTR_DISABLE_PREPARES", PDO_PGSQL_ATTR_DISABLE_PREPARES);
-	REGISTER_PDO_CLASS_CONST_LONG("PGSQL_TRANSACTION_IDLE", (zend_long)PGSQL_TRANSACTION_IDLE);
-	REGISTER_PDO_CLASS_CONST_LONG("PGSQL_TRANSACTION_ACTIVE", (zend_long)PGSQL_TRANSACTION_ACTIVE);
-	REGISTER_PDO_CLASS_CONST_LONG("PGSQL_TRANSACTION_INTRANS", (zend_long)PGSQL_TRANSACTION_INTRANS);
-	REGISTER_PDO_CLASS_CONST_LONG("PGSQL_TRANSACTION_INERROR", (zend_long)PGSQL_TRANSACTION_INERROR);
-	REGISTER_PDO_CLASS_CONST_LONG("PGSQL_TRANSACTION_UNKNOWN", (zend_long)PGSQL_TRANSACTION_UNKNOWN);
 
 	PdoPgsql_ce = register_class_Pdo_Pgsql(pdo_dbh_ce);
 	PdoPgsql_ce->create_object = pdo_dbh_new;

ext/pdo_pgsql/pdo_pgsql.stub.php

@@ -18,21 +18,6 @@ class Pgsql extends \PDO
     public const int ATTR_RESULT_MEMORY_SIZE = UNKNOWN;
 #endif
 
-    /** @cvalue PGSQL_TRANSACTION_IDLE */
-    public const int TRANSACTION_IDLE = UNKNOWN;
-
-    /** @cvalue PGSQL_TRANSACTION_ACTIVE */
-    public const int TRANSACTION_ACTIVE = UNKNOWN;
-
-    /** @cvalue PGSQL_TRANSACTION_INTRANS */
-    public const int TRANSACTION_INTRANS = UNKNOWN;
-
-    /**  @cvalue PGSQL_TRANSACTION_INERROR */
-    public const int TRANSACTION_INERROR = UNKNOWN;
-
-    /** @cvalue PGSQL_TRANSACTION_UNKNOWN */
-    public const int TRANSACTION_UNKNOWN = UNKNOWN;
-
     public function escapeIdentifier(string $input): string {}
 
     public function copyFromArray(string $tableName, array $rows, string $separator = "\t", string $nullAs = "\\\\N", ?string $fields = null): bool {}

ext/pdo_pgsql/pdo_pgsql_arginfo.h

@@ -104,14 +104,6 @@ struct pdo_pgsql_lob_self {
 	Oid oid;
 };
 
-enum pdo_pgsql_specific_constants {
-	PGSQL_TRANSACTION_IDLE = PQTRANS_IDLE,
-	PGSQL_TRANSACTION_ACTIVE = PQTRANS_ACTIVE,
-	PGSQL_TRANSACTION_INTRANS = PQTRANS_INTRANS,
-	PGSQL_TRANSACTION_INERROR = PQTRANS_INERROR,
-	PGSQL_TRANSACTION_UNKNOWN = PQTRANS_UNKNOWN
-};
-
 php_stream *pdo_pgsql_create_lob_stream(zend_object *pdh, int lfd, Oid oid);
 extern const php_stream_ops pdo_pgsql_lob_stream_ops;