diff --git a/.github/workflows/nightly-results.yml b/.github/workflows/nightly-results.yml index c1c4da72ca56..a222582da1c6 100644 --- a/.github/workflows/nightly-results.yml +++ b/.github/workflows/nightly-results.yml @@ -13,4 +13,4 @@ jobs: - run: | export DEBIAN_FRONTEND=noninteractive sudo apt-get install -y curl - curl -X POST -H 'Content-type: application/json' --data '{"attachments": [{"text": "Job in *nightly* failed", "footer": "<${{ github.event.workflow_run.jobs_url }}|View Run>", "color": "danger", "mrkdwn_in": ["text"]}]}' ${{ secrets.ACTION_MONITORING_SLACK }} + curl -X POST -H 'Content-type: application/json' --data '{"attachments": [{"text": "Job(s) in *nightly* failed", "footer": "<${{ github.event.workflow_run.html_url }}|View Run>", "color": "danger", "mrkdwn_in": ["text"]}]}' ${{ secrets.ACTION_MONITORING_SLACK }} diff --git a/ext/uri/uri_parser_php_parse_url.c b/ext/uri/uri_parser_php_parse_url.c index a185068a0392..8cee29e8f0c6 100644 --- a/ext/uri/uri_parser_php_parse_url.c +++ b/ext/uri/uri_parser_php_parse_url.c @@ -165,7 +165,7 @@ static void uri_parser_php_parse_url_destroy(void *uri) php_url_free(parse_url_uri); } -const php_uri_parser php_uri_parser_php_parse_url = { +PHPAPI const php_uri_parser php_uri_parser_php_parse_url = { .name = PHP_URI_PARSER_PHP_PARSE_URL, .parse = uri_parser_php_parse_url_parse, .clone = NULL, diff --git a/ext/uri/uri_parser_php_parse_url.h b/ext/uri/uri_parser_php_parse_url.h index ae2d862faf40..6cf532db8352 100644 --- a/ext/uri/uri_parser_php_parse_url.h +++ b/ext/uri/uri_parser_php_parse_url.h @@ -20,6 +20,6 @@ #include "php_uri_common.h" -extern const php_uri_parser php_uri_parser_php_parse_url; +PHPAPI extern const php_uri_parser php_uri_parser_php_parse_url; #endif diff --git a/ext/uri/uri_parser_rfc3986.c b/ext/uri/uri_parser_rfc3986.c index 628b73b123f6..30707fde1302 100644 --- a/ext/uri/uri_parser_rfc3986.c +++ b/ext/uri/uri_parser_rfc3986.c @@ -615,7 +615,7 @@ static void php_uri_parser_rfc3986_destroy(void *uri) efree(uriparser_uris); } -const php_uri_parser php_uri_parser_rfc3986 = { +PHPAPI const php_uri_parser php_uri_parser_rfc3986 = { .name = PHP_URI_PARSER_RFC3986, .parse = php_uri_parser_rfc3986_parse, .clone = php_uri_parser_rfc3986_clone, diff --git a/ext/uri/uri_parser_rfc3986.h b/ext/uri/uri_parser_rfc3986.h index b6d42441db7a..fbbfefb30af6 100644 --- a/ext/uri/uri_parser_rfc3986.h +++ b/ext/uri/uri_parser_rfc3986.h @@ -19,7 +19,7 @@ #include "php_uri_common.h" -extern const php_uri_parser php_uri_parser_rfc3986; +PHPAPI extern const php_uri_parser php_uri_parser_rfc3986; typedef struct php_uri_parser_rfc3986_uris php_uri_parser_rfc3986_uris; diff --git a/ext/uri/uri_parser_whatwg.c b/ext/uri/uri_parser_whatwg.c index fab228a2d70c..954753142885 100644 --- a/ext/uri/uri_parser_whatwg.c +++ b/ext/uri/uri_parser_whatwg.c @@ -621,7 +621,7 @@ static void php_uri_parser_whatwg_destroy(void *uri) lxb_url_destroy(lexbor_uri); } -const php_uri_parser php_uri_parser_whatwg = { +PHPAPI const php_uri_parser php_uri_parser_whatwg = { .name = PHP_URI_PARSER_WHATWG, .parse = php_uri_parser_whatwg_parse, .clone = php_uri_parser_whatwg_clone, diff --git a/ext/uri/uri_parser_whatwg.h b/ext/uri/uri_parser_whatwg.h index 71d6ee3903bf..e8bbb585fd66 100644 --- a/ext/uri/uri_parser_whatwg.h +++ b/ext/uri/uri_parser_whatwg.h @@ -20,7 +20,7 @@ #include "php_uri_common.h" #include "lexbor/url/url.h" -extern const php_uri_parser php_uri_parser_whatwg; +PHPAPI extern const php_uri_parser php_uri_parser_whatwg; lxb_url_t *php_uri_parser_whatwg_parse_ex(const char *uri_str, size_t uri_str_len, const lxb_url_t *lexbor_base_url, zval *errors, bool silent); diff --git a/run-tests.php b/run-tests.php index ac5fc91118e4..d0befa3738df 100755 --- a/run-tests.php +++ b/run-tests.php @@ -2811,6 +2811,11 @@ function is_flaky(TestFile $test): bool if ($test->hasSection('FLAKY')) { return true; } + if ($test->hasSection('SKIPIF')) { + if (strpos($test->getSection('SKIPIF'), 'SKIP_PERF_SENSITIVE') !== false) { + return true; + } + } if (!$test->hasSection('FILE')) { return false; }