Use more precise naming

Author: wugeer

src/dialect/mod.rs

@@ -591,13 +591,13 @@ pub trait Dialect: Debug + Any {
         false
     }
 
-    /// Returns true if the dialect supports `listen` clause
-    fn supports_listen_clause(&self) -> bool {
+    /// Returns true if the dialect supports the `LISTEN` statement
+    fn supports_listen(&self) -> bool {
         false
     }
 
-    /// Returns true if the dialect supports `notify` clause
-    fn supports_notify_clause(&self) -> bool {
+    /// Returns true if the dialect supports the `NOTIFY` statement
+    fn supports_notify(&self) -> bool {
         false
     }
 }

src/dialect/postgresql.rs

@@ -193,12 +193,12 @@ impl Dialect for PostgreSqlDialect {
     }
 
     /// see <https://www.postgresql.org/docs/current/sql-listen.html>
-    fn supports_listen_clause(&self) -> bool {
+    fn supports_listen(&self) -> bool {
         true
     }
 
     /// see <https://www.postgresql.org/docs/current/sql-notify.html>
-    fn supports_notify_clause(&self) -> bool {
+    fn supports_notify(&self) -> bool {
         true
     }
 }

src/parser/mod.rs

@@ -534,8 +534,8 @@ impl<'a> Parser<'a> {
                 Keyword::MERGE => self.parse_merge(),
                 // `LISTEN` and `NOTIFY` are Postgres-specific
                 // syntaxes. They are used for Postgres statement.
-                Keyword::LISTEN if self.dialect.supports_listen_clause() => self.parse_listen(),
-                Keyword::NOTIFY if self.dialect.supports_notify_clause() => self.parse_notify(),
+                Keyword::LISTEN if self.dialect.supports_listen() => self.parse_listen(),
+                Keyword::NOTIFY if self.dialect.supports_notify() => self.parse_notify(),
                 // `PRAGMA` is sqlite specific https://www.sqlite.org/pragma.html
                 Keyword::PRAGMA => self.parse_pragma(),
                 Keyword::UNLOAD => self.parse_unload(),

tests/sqlparser_common.rs

@@ -11463,7 +11463,7 @@ fn test_try_convert() {
 
 #[test]
 fn parse_listen_channel() {
-    let dialects = all_dialects_where(|d| d.supports_listen_clause());
+    let dialects = all_dialects_where(|d| d.supports_listen());
 
     match dialects.verified_stmt("LISTEN test1") {
         Statement::LISTEN { channel } => {
@@ -11477,7 +11477,7 @@ fn parse_listen_channel() {
         ParserError::ParserError("Expected: identifier, found: *".to_string())
     );
 
-    let dialects = all_dialects_where(|d| !d.supports_listen_clause());
+    let dialects = all_dialects_where(|d| !d.supports_listen());
 
     assert_eq!(
         dialects.parse_sql_statements("LISTEN test1").unwrap_err(),
@@ -11487,7 +11487,7 @@ fn parse_listen_channel() {
 
 #[test]
 fn parse_notify_channel() {
-    let dialects = all_dialects_where(|d| d.supports_notify_clause());
+    let dialects = all_dialects_where(|d| d.supports_notify());
 
     match dialects.verified_stmt("NOTIFY test1") {
         Statement::NOTIFY { channel, payload } => {
@@ -11523,7 +11523,7 @@ fn parse_notify_channel() {
         "NOTIFY test1",
         "NOTIFY test1, 'this is a test notification'",
     ];
-    let dialects = all_dialects_where(|d| !d.supports_notify_clause());
+    let dialects = all_dialects_where(|d| !d.supports_notify());
 
     for &sql in &sql_statements {
         assert_eq!(