Make constants in IdentityVerificationPrecompleteCheck private

A follow-up to #1530

Author: banterCZ

enrollment-server-onboarding/src/main/java/com/wultra/app/onboardingserver/impl/service/IdentityVerificationPrecompleteCheck.java

@@ -55,14 +55,14 @@
 @AllArgsConstructor
 class IdentityVerificationPrecompleteCheck {
 
-    public static final String SOME_DOCUMENTS_NOT_ACCEPTED = "Some documents not accepted";
-    public static final String REQUIRED_DOCUMENTS_NOT_PRESENT = "Required documents not present";
-    public static final String NOT_VALID_PHASE_AND_STATE = "Not valid phase and state";
-    public static final String NOT_VALID_USER_VERIFICATION_OTP = "Not valid user verification OTP";
-    public static final String NOT_VALID_ACTIVATION_OTP = "Not valid activation OTP";
-    public static final String NOT_VALID_ACTIVATION = "Activation is not valid";
-    public static final String NOT_VALID_SCA = "Did not pass SCA";
-    public static final String NOT_VALID_TARGET_ACTIVATION = "Target activation is not valid";
+    private static final String SOME_DOCUMENTS_NOT_ACCEPTED = "Some documents not accepted";
+    private static final String REQUIRED_DOCUMENTS_NOT_PRESENT = "Required documents not present";
+    private static final String NOT_VALID_PHASE_AND_STATE = "Not valid phase and state";
+    private static final String NOT_VALID_USER_VERIFICATION_OTP = "Not valid user verification OTP";
+    private static final String NOT_VALID_ACTIVATION_OTP = "Not valid activation OTP";
+    private static final String NOT_VALID_ACTIVATION = "Activation is not valid";
+    private static final String NOT_VALID_SCA = "Did not pass SCA";
+    private static final String NOT_VALID_TARGET_ACTIVATION = "Target activation is not valid";
 
     private final IdentityVerificationConfig identityVerificationConfig;
 

enrollment-server-onboarding/src/test/java/com/wultra/app/onboardingserver/impl/service/IdentityVerificationPrecompleteCheckTest.java

@@ -40,7 +40,6 @@
 
 import static com.wultra.app.enrollmentserver.model.enumeration.IdentityVerificationPhase.*;
 import static com.wultra.app.enrollmentserver.model.enumeration.IdentityVerificationStatus.*;
-import static com.wultra.app.onboardingserver.impl.service.IdentityVerificationPrecompleteCheck.*;
 import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.any;
@@ -152,7 +151,7 @@ void testProcessDocumentVerificationResult_invalidVerificationOtp() throws Excep
         final var result = tested.evaluate(idVerification);
 
         assertFalse(result.isSuccessful());
-        assertEquals(NOT_VALID_USER_VERIFICATION_OTP, result.getErrorDetail());
+        assertEquals("Not valid user verification OTP", result.getErrorDetail());
     }
 
     @Test
@@ -175,7 +174,7 @@ void testProcessDocumentVerificationResult_invalidActivationOtp() throws Excepti
         final var result = tested.evaluate(idVerification);
 
         assertFalse(result.isSuccessful());
-        assertEquals(NOT_VALID_ACTIVATION_OTP, result.getErrorDetail());
+        assertEquals("Not valid activation OTP", result.getErrorDetail());
     }
 
     @Test
@@ -294,7 +293,7 @@ void testProcessDocumentVerificationResult_invalidActivation() throws Exception
         final var result = tested.evaluate(idVerification);
 
         assertFalse(result.isSuccessful());
-        assertEquals(NOT_VALID_ACTIVATION, result.getErrorDetail());
+        assertEquals("Activation is not valid", result.getErrorDetail());
     }
 
     @Test
@@ -310,7 +309,7 @@ void testProcessDocumentVerificationResult_failedDocument() throws Exception {
         final var result = tested.evaluate(idVerification);
 
         assertFalse(result.isSuccessful());
-        assertEquals(SOME_DOCUMENTS_NOT_ACCEPTED, result.getErrorDetail());
+        assertEquals("Some documents not accepted", result.getErrorDetail());
     }
 
     @Test
@@ -329,7 +328,7 @@ void testProcessDocumentVerificationResult_missingRequiredDocuments() throws Exc
         final var result = tested.evaluate(idVerification);
 
         assertFalse(result.isSuccessful());
-        assertEquals(REQUIRED_DOCUMENTS_NOT_PRESENT, result.getErrorDetail());
+        assertEquals("Required documents not present", result.getErrorDetail());
     }
 
     @Test
@@ -344,7 +343,7 @@ void testProcessDocumentVerificationResult_invalidStatus() throws Exception {
         final var result = tested.evaluate(idVerification);
 
         assertFalse(result.isSuccessful());
-        assertEquals(NOT_VALID_PHASE_AND_STATE, result.getErrorDetail());
+        assertEquals("Not valid phase and state", result.getErrorDetail());
     }
 
     @Test