chore(connectrpc): remove pointless TestConnectRPC_ClientConcurrency test

Test only verified concurrent requests don't crash - not meaningful
coverage. Also removed associated golden file.

Author: asoorm

router-tests/connectrpc/connectrpc_client_test.go

@@ -6,7 +6,6 @@ import (
 	"encoding/json"
 	"net"
 	"net/http"
-	"sync/atomic"
 	"testing"
 
 	"connectrpc.com/connect"
@@ -282,88 +281,3 @@ func TestConnectRPC_ClientErrorHandling(t *testing.T) {
 		g.Assert(t, "error_http_500", errorJSON)
 	})
 }
-
-// TestConnectRPC_ClientConcurrency tests concurrent requests with generated client
-func TestConnectRPC_ClientConcurrency(t *testing.T) {
-	t.Parallel()
-
-	g := goldie.New(
-		t,
-		goldie.WithFixtureDir("testdata/connectrpc"),
-		goldie.WithNameSuffix(".json"),
-		goldie.WithDiffEngine(goldie.ClassicDiff),
-	)
-
-	var requestCount int64
-	handler := func(w http.ResponseWriter, r *http.Request) {
-		atomic.AddInt64(&requestCount, 1)
-		w.Header().Set("Content-Type", "application/json")
-		w.WriteHeader(http.StatusOK)
-		_, _ = w.Write([]byte(`{
-			"data": {
-				"employee": {
-					"id": 1,
-					"tag": "employee-1",
-					"details": {
-						"forename": "John",
-						"surname": "Doe"
-					}
-				}
-			}
-		}`))
-	}
-	
-	ts := NewTestConnectRPCServer(t, ConnectRPCServerOptions{
-		GraphQLHandler: handler,
-	})
-	
-	err := ts.Start()
-	require.NoError(t, err)
-
-	client := employeev1connect.NewEmployeeServiceClient(
-		http.DefaultClient,
-		"http://"+ts.Addr().String(),
-	)
-
-	// Make 10 concurrent requests
-	const numRequests = 10
-	results := make(chan error, numRequests)
-	type responseData struct {
-		resp *connect.Response[employeev1.GetEmployeeByIdResponse]
-		err  error
-	}
-	responses := make(chan responseData, numRequests)
-
-	for i := 0; i < numRequests; i++ {
-		go func() {
-			req := connect.NewRequest(&employeev1.GetEmployeeByIdRequest{
-				EmployeeId: 1,
-			})
-			resp, err := client.GetEmployeeById(context.Background(), req)
-			responses <- responseData{resp: resp, err: err}
-			results <- err
-		}()
-	}
-
-	// Collect results
-	for i := 0; i < numRequests; i++ {
-		err := <-results
-		assert.NoError(t, err)
-	}
-
-	assert.Equal(t, int64(numRequests), atomic.LoadInt64(&requestCount), "should have made all requests")
-
-	// Verify response consistency by checking one of the responses
-	select {
-	case respData := <-responses:
-		if respData.err == nil && respData.resp != nil && respData.resp.Msg != nil && respData.resp.Msg.Employee != nil {
-			employeeJSON, err := json.MarshalIndent(respData.resp.Msg.Employee, "", "  ")
-			require.NoError(t, err)
-			g.Assert(t, "concurrent_response", employeeJSON)
-		} else {
-			t.Fatal("invalid response received")
-		}
-	default:
-		t.Fatal("no responses received")
-	}
-}