chore: address review comments

pepol · pepol · commit 7255846c7a29 · 2026-04-01T15:33:41.000+02:00
diff --git a/controlplane/src/core/blobstorage/dual.ts b/controlplane/src/core/blobstorage/dual.ts
@@ -23,11 +23,7 @@ export class DualBlobStorage implements BlobStorage {
   }
 
   async getObject(data: { key: string; abortSignal?: AbortSignal }): Promise<BlobObject> {
-    try {
-      return await this.primary.getObject(data);
-    } catch {
-      return await this.secondary.getObject(data);
-    }
+    return await Promise.any([this.primary.getObject(data), this.secondary.getObject(data)]);
   }
 
   async removeDirectory(data: { key: string; abortSignal?: AbortSignal }): Promise<number> {
diff --git a/controlplane/src/core/env.schema.ts b/controlplane/src/core/env.schema.ts
@@ -167,7 +167,7 @@ export const envVariables = z
      */
     S3_FAILOVER_STORAGE_URL: z.string().optional(),
     S3_FAILOVER_ENDPOINT: z.string().optional(),
-    S3_FAILOVER_REGION: z.string().optional(),
+    S3_FAILOVER_REGION: z.string().default('auto'),
     S3_FAILOVER_ACCESS_KEY_ID: z.string().optional(),
     S3_FAILOVER_SECRET_ACCESS_KEY: z.string().optional(),
     S3_FAILOVER_FORCE_PATH_STYLE: z

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,7 @@ export class DualBlobStorage implements BlobStorage {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`async getObject(data: { key: string; abortSignal?: AbortSignal }): Promise<BlobObject> {`
`26`		`- try {`
`27`		`- return await this.primary.getObject(data);`
`28`		`- } catch {`
`29`		`- return await this.secondary.getObject(data);`
`30`		`- }`
	`26`	`+ return await Promise.any([this.primary.getObject(data), this.secondary.getObject(data)]);`
`31`	`27`	`}`
`32`	`28`
`33`	`29`	`async removeDirectory(data: { key: string; abortSignal?: AbortSignal }): Promise<number> {`