Skip to content

Commit a671be6

Browse files
committed
chore: small improvement
1 parent 9c0b193 commit a671be6

3 files changed

Lines changed: 11 additions & 9 deletions

File tree

composition-go/index.global.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

composition/src/resolvability-graph/utils/utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,12 @@ export function generateSelectionSetSegments(
195195
let outputEnd = '';
196196
let shouldTruncate = false;
197197
const truncatedNumber = pathNodes.length - limit * 2;
198-
if (limit > 0 && pathNodes.length > limit * 2) {
198+
if (limit > 0 && pathNodes.length > limit * 2 + 1) {
199199
shouldTruncate = true;
200-
pathNodes.splice(limit, truncatedNumber);
200+
pathNodes.splice(limit + 1, truncatedNumber - 1);
201201
}
202202
for (let i = 0; i < pathNodes.length; i++) {
203-
if (shouldTruncate && i === limit) {
203+
if (shouldTruncate && i === limit + 1) {
204204
outputStart += LITERAL_SPACE.repeat(i + 1) + `... # and ${truncatedNumber} truncated selections\n`;
205205
}
206206
outputStart += LITERAL_SPACE.repeat(i + 1) + pathNodes[i] + ` {\n`;

composition/tests/v1/error-length.test.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,20 @@ describe('Field resolvability error tests', () => {
3939
});
4040

4141
test('that a custom selection limit is respected successfully', () => {
42-
const fieldPath = 'query.query.a.b.c.d.e.f.g.h.i.j.k.l.m.n.o.p.q.r.s.t.u.w.x.y.z.aa.bb.cc.dd.ee';
42+
const fieldPath = 'query.rootField.a.b.c.d.e.f.g.h.i.j.k.l.m.n.o.p.q.r.s.t.u.w.x.y.z.aa.bb.cc.dd.ee';
4343
const { outputStart, outputEnd, pathNodes } = generateSelectionSetSegments(fieldPath, 1);
4444
const render = renderSelectionSet({ outputStart, outputEnd, pathNodes }, {
4545
isLeaf: true,
4646
name: 'id',
4747
} as GraphFieldData);
4848

49-
expect(pathNodes.length).toBe(2);
49+
expect(pathNodes.length).toBe(3);
5050
expect(render).toBe(` query {
51-
... # and 30 truncated selections
52-
ee {
53-
id <--
51+
rootField {
52+
... # and 30 truncated selections
53+
ee {
54+
id <--
55+
}
5456
}
5557
}
5658
`);

0 commit comments

Comments
 (0)