Skip to content

Commit dddbf62

Browse files
authored
fix: add the startup config value to oci plugin startup (#2285)
1 parent 25bc8a2 commit dddbf62

File tree

2 files changed

+26
-0
lines changed

2 files changed

+26
-0
lines changed

router/pkg/grpcconnector/grpcpluginoci/grpc_oci_plugin.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ func NewGRPCOCIPlugin(config GRPCPluginConfig) (*GRPCPlugin, error) {
7979
registryPassword: config.RegistryToken,
8080

8181
tracer: config.Tracer,
82+
startupConfig: config.StartupConfig,
8283
getTraceAttributes: config.GetTraceAttributes,
8384
}, nil
8485
}

router/pkg/grpcconnector/grpcpluginoci/grpc_oci_plugin_test.go

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package grpcpluginoci
22

33
import (
4+
"github.com/wundergraph/cosmo/router/pkg/grpcconnector/grpccommon"
45
"testing"
56

67
"github.com/stretchr/testify/assert"
@@ -66,3 +67,27 @@ func TestNewGRPCOCIPlugin(t *testing.T) {
6667
})
6768
}
6869
}
70+
71+
func TestNewGRPCOCIPluginWithStartupConfig(t *testing.T) {
72+
t.Run("successful creation with startup config", func(t *testing.T) {
73+
telemetry := &grpccommon.GRPCTelemetry{
74+
Tracing: &grpccommon.GRPCTracing{
75+
Sampler: 1.0,
76+
},
77+
}
78+
plugin := GRPCPluginConfig{
79+
Logger: zap.NewNop(),
80+
ImageRef: "cosmo-registry.wundergraph-test/org/image",
81+
RegistryToken: "lalala",
82+
StartupConfig: grpccommon.GRPCStartupParams{
83+
Telemetry: telemetry,
84+
},
85+
}
86+
87+
grpcPlugin, err := NewGRPCOCIPlugin(plugin)
88+
assert.NoError(t, err)
89+
90+
assert.NotNil(t, grpcPlugin.startupConfig.Telemetry)
91+
assert.Equal(t, grpcPlugin.startupConfig.Telemetry, telemetry)
92+
})
93+
}

0 commit comments

Comments
 (0)