Skip to content

Commit 7667b41

Browse files
committed
Remove of Optional in Kotlinx Serialization
1 parent 5e51a5c commit 7667b41

File tree

7 files changed

+9
-12
lines changed

7 files changed

+9
-12
lines changed

src/main/kotlin/wu/seal/jsontokotlin/IConfigManager.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@ interface IConfigManager {
136136
var customAnnotationClassImportdeclarationString: String
137137
get() = if (isTestModel) TestConfig.customAnnotaionImportClassString else PropertiesComponent.getInstance().getValue(
138138
USER_CUSTOM_JSON_LIB_ANNOTATION_IMPORT_CLASS, "import kotlinx.serialization.SerialName\n" +
139-
"import kotlinx.serialization.Serializable" + "\n"
140-
+ "import kotlinx.serialization.Optional"
139+
"import kotlinx.serialization.Serializable"
141140
)
142141
set(value) = if (isTestModel) {
143142
TestConfig.customAnnotaionImportClassString = value
@@ -148,7 +147,7 @@ interface IConfigManager {
148147
var customPropertyAnnotationFormatString: String
149148
get() = if (isTestModel) TestConfig.customPropertyAnnotationFormatString else PropertiesComponent.getInstance().getValue(
150149
USER_CUSTOM_JSON_LIB_ANNOTATION_FORMAT_STRING,
151-
"@Optional\n@SerialName(\"%s\")"
150+
"@SerialName(\"%s\")"
152151
)
153152
set(value) = if (isTestModel) {
154153
TestConfig.customPropertyAnnotationFormatString = value

src/main/kotlin/wu/seal/jsontokotlin/codeannotations/SerializablePropertyAnnotationTemplate.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class SerializablePropertyAnnotationTemplate(val rawName: String) : AnnotationTe
66

77
companion object{
88

9-
const val annotationFormat = "@Optional\n@SerialName(\"%s\")"
9+
const val annotationFormat = "@SerialName(\"%s\")"
1010
}
1111

1212
private val annotation = Annotation(annotationFormat, rawName)

src/main/kotlin/wu/seal/jsontokotlin/interceptor/annotations/serializable/AddSerializableAnnotationClassImportDeclarationInterceptor.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class AddSerializableAnnotationClassImportDeclarationInterceptor : IImportClassD
88

99

1010
val propertyAnnotationImportClassString = "import kotlinx.serialization.SerialName\n" +
11-
"import kotlinx.serialization.Serializable"+"\nimport kotlinx.serialization.Optional"
11+
"import kotlinx.serialization.Serializable"
1212

1313
return originClassImportDeclaration.append(propertyAnnotationImportClassString)
1414
}

src/main/kotlin/wu/seal/jsontokotlin/test/TestConfig.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ object TestConfig {
2626
var defaultValueStrategy = DefaultValueStrategy.AvoidNull
2727
var isNestedClassModel = true
2828

29-
var customPropertyAnnotationFormatString = "@Optional\n@SerialName(\"%s\")"
29+
var customPropertyAnnotationFormatString = "@SerialName(\"%s\")"
3030
var customAnnotaionImportClassString = "import kotlinx.serialization.SerialName\n" +
31-
"import kotlinx.serialization.Serializable" + "\n" + "import kotlinx.serialization.Optional"
31+
"import kotlinx.serialization.Serializable"
3232

3333
var customClassAnnotationFormatString = "@Serializable"
3434

@@ -55,9 +55,9 @@ object TestConfig {
5555
propertyTypeStrategy = PropertyTypeStrategy.NotNullable
5656
defaultValueStrategy = DefaultValueStrategy.AvoidNull
5757
isNestedClassModel = true
58-
customPropertyAnnotationFormatString = "@Optional\n@SerialName(\"%s\")"
58+
customPropertyAnnotationFormatString = "@SerialName(\"%s\")"
5959
customAnnotaionImportClassString = "import kotlinx.serialization.SerialName\n" +
60-
"import kotlinx.serialization.Serializable" + "\n" + "import kotlinx.serialization.Optional"
60+
"import kotlinx.serialization.Serializable"
6161

6262
customClassAnnotationFormatString = "@Serializable"
6363

src/test/kotlin/wu/seal/jsontokotlin/KotlinCodeMakerTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class KotlinCodeMakerTest {
123123
fun makeKotlinDataWithCustomAnnotation() {
124124
TestConfig.targetJsonConvertLib = TargetJsonConverter.Custom
125125
TestConfig.isNestedClassModel = false
126-
TestConfig.customPropertyAnnotationFormatString = "@Optional\n@SerialName(\"%s\")"
126+
TestConfig.customPropertyAnnotationFormatString = "@SerialName(\"%s\")"
127127
TestConfig.customClassAnnotationFormatString = "@Serializable"
128128
TestConfig.customAnnotaionImportClassString =
129129
"import kotlinx.serialization.SerialName\nimport kotlinx.serialization.Serializable"

src/test/kotlin/wu/seal/jsontokotlin/interceptor/annotations/custom/AddCustomAnnotationInterceptorTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ class AddCustomAnnotationInterceptorTest {
1414

1515
private val expectedDataClass = """@Serializable
1616
data class Test(
17-
@Optional
1817
@SerialName("M_property"")
1918
val mProperty: Int // 123
2019
)"""

src/test/kotlin/wu/seal/jsontokotlin/interceptor/annotations/serializable/AddSerializableAnnotationInterceptorTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ class AddSerializableAnnotationInterceptorTest {
1414

1515
private val expectedDataClass = """@Serializable
1616
data class Test(
17-
@Optional
1817
@SerialName("M_property"")
1918
val mProperty: Int // 123
2019
)"""

0 commit comments

Comments
 (0)