Wrap all string autocomplete values in quotes, not just those containing whitespace

Author: jeremylenz

CHANGELOG.rdoc

@@ -6,6 +6,8 @@ Please add an entry to the "Unreleased changes" section in your pull requests.
 
 === Unreleased changes
 
+- Autocomplete now wraps all strings in quotes, not just those containing whitespace
+
 === Version 4.1.10
 
 - Fix querying through associations in Rails 6.1 (undefined method join_keys) (#201)

lib/scoped_search/auto_complete_builder.rb

@@ -215,7 +215,7 @@ def complete_value_from_db(field, special_values, val)
         .distinct
         .map(&field.field)
         .compact
-        .map { |v| v.to_s =~ /\s/ ? "\"#{v.gsub('"', '\"')}\"" : v }
+        .map { |v| v.is_a?(String) ? "\"#{v.gsub('"', '\"')}\"" : v }
     end
 
     def completer_scope(field)

spec/integration/auto_complete_spec.rb

@@ -169,10 +169,10 @@ class ::Infoo < ::Foo
       end
 
       it "should complete values should contain baz" do
-        Foo.complete_for('explicit = ').should contain('explicit =  baz')
+        Foo.complete_for('explicit = ').should contain('explicit =  "baz"')
       end
 
-      it "should complete values with quotes where required" do
+      it "should complete values with quotes where value is a string" do
         Foo.complete_for('alias = ').should contain('alias =  "temp \"2\""')
       end
     end