Fix a bug missed return (go-gitea#35655) (go-gitea#35671)

GiteaBot · lunny · web-flow · commit b854930a96b2 · 2025-10-15T07:30:46.000Z
Backport go-gitea#35655 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
diff --git a/routers/web/auth/oauth2_provider.go b/routers/web/auth/oauth2_provider.go
@@ -639,6 +639,7 @@ func handleAuthorizationCode(ctx *context.Context, form forms.AccessTokenForm, s
 			ErrorCode:        oauth2_provider.AccessTokenErrorCodeInvalidRequest,
 			ErrorDescription: "cannot proceed your request",
 		})
+		return
 	}
 	resp, tokenErr := oauth2_provider.NewAccessTokenResponse(ctx, authorizationCode.Grant, serverKey, clientKey)
 	if tokenErr != nil {

Original file line number	Diff line number	Diff line change
`@@ -639,6 +639,7 @@ func handleAuthorizationCode(ctx *context.Context, form forms.AccessTokenForm, s`
`639`	`639`	`ErrorCode: oauth2_provider.AccessTokenErrorCodeInvalidRequest,`
`640`	`640`	`ErrorDescription: "cannot proceed your request",`
`641`	`641`	`})`
	`642`	`+ return`
`642`	`643`	`}`
`643`	`644`	`resp, tokenErr := oauth2_provider.NewAccessTokenResponse(ctx, authorizationCode.Grant, serverKey, clientKey)`
`644`	`645`	`if tokenErr != nil {`