Skip to content

Commit 1272e2e

Browse files
committed
chore: Fix markdown lint errors and add upgrade @aklinker1/check to
include markdownlint
1 parent db16602 commit 1272e2e

File tree

4 files changed

+16
-7
lines changed

4 files changed

+16
-7
lines changed

.github/workflows/validate.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ jobs:
2323
- name: Basic Checks
2424
run: pnpm check
2525

26-
- name: Markdownlint
27-
run: pnpm check:md
28-
2926
builds:
3027
name: Builds
3128
runs-on: ubuntu-22.04

docs/guide/resources/upgrading.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,10 @@ See <https://github.com/wxt-dev/wxt/issues/784>
5454
To upgrade, you have two options:
5555

5656
1. **Stop using the polyfill**
57+
5758
- If you're already using `extensionApi: "chrome"`, then you're not using the polyfill and there is nothing to change!
5859
- Otherwise there is only one change: `browser.runtime.onMessage` no longer supports using promises to return a response:
60+
5961
```ts
6062
browser.runtime.onMessage.addListener(async () => { // [!code --]
6163
const res = await someAsyncWork(); // [!code --]
@@ -67,6 +69,7 @@ To upgrade, you have two options:
6769
return true; // [!code ++]
6870
});
6971
```
72+
7073
2. **Continue using the polyfill** - If you want to keep using the polyfill, you can! One less thing to worry about during this upgrade.
7174
7275
- Install `webextension-polyfill` and WXT's [new polyfill module](https://www.npmjs.com/package/@wxt-dev/webextension-polyfill):

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"packageManager": "[email protected]",
88
"scripts": {
99
"check": "check && pnpm -r --sequential run check",
10-
"check:md": "markdownlint .",
1110
"test": "pnpm -r --sequential run test run",
1211
"test:coverage": "pnpm -r --sequential run test:coverage",
1312
"prepare": "simple-git-hooks",
@@ -19,7 +18,7 @@
1918
},
2019
"devDependencies": {
2120
"@aklinker1/buildc": "^1.1.4",
22-
"@aklinker1/check": "2.0.0",
21+
"@aklinker1/check": "^2.1.0",
2322
"@commitlint/config-conventional": "^19.8.0",
2423
"@commitlint/types": "^19.8.0",
2524
"@types/fs-extra": "^11.0.4",

pnpm-lock.yaml

Lines changed: 12 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)