You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/skills/pr-review/SKILL.md
+11-6Lines changed: 11 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -56,13 +56,17 @@ Before acting on any review comment or suggestion, classify it by importance:
56
56
|-------|----------|--------|
57
57
|**P1 — Must Fix**| Bug, security issue, broken behavior, API contract violation, CI failure | Fix immediately |
58
58
|**P2 — Should Fix**| Correctness risk, meaningful maintainability improvement, clear code smell with real impact | Fix with brief justification |
59
-
|**P3 — Optional**| Style preference, minor naming nitpick, debatable design choice, "could be cleaner" |**Do NOT auto-fix** — surface to user for decision|
59
+
|**P3 — Conditional**| Style preference, minor naming, "could be cleaner" |Fix if it aligns with best practices **and** the change is safe + trivial; defer if complex or has any potential functional impact|
60
60
|**P4 — Reject**| Contradicts project conventions, introduces unnecessary complexity, or is factually wrong | Reject with explanation |
61
61
62
62
**Rules:**
63
-
-**Do not implement P3 suggestions automatically.** Note them in the final summary and let the user decide.
63
+
- For **P3**, apply this two-question test before touching the code:
64
+
1.**Best practice?** — Does the change follow language/framework conventions (e.g. prefer imports over FQNs, use existing imports, standard patterns)?
65
+
2.**Safe & trivial?** — Is the diff mechanical with zero risk of behavioral change and low effort?
66
+
- Both **yes** → fix it silently, mark thread resolved.
67
+
- Either **no** → do NOT modify code; record in the summary table and let the user decide.
64
68
-**Do not add comments to code** unless the comment explains non-obvious logic that is truly necessary. Never add comments just to acknowledge a review suggestion was applied.
65
-
- When in doubt about importance, prefer the lower severity (P3/P4) and defer to the user rather than making the change.
69
+
- When the two-question test is ambiguous, prefer deferring rather than guessing.
66
70
67
71
## Procedure
68
72
@@ -80,7 +84,7 @@ Before acting on any review comment or suggestion, classify it by importance:
80
84
3.**Address review comments** — apply the Review Restraint Policy to each comment:
81
85
- P1/P2: implement the fix, then **immediately resolve the thread** using the GraphQL mutation above
82
86
- Outdated threads: resolve them regardless of priority (no action needed, just mark resolved)
83
-
- P3: record in summary, do **not** modify code, ask user
87
+
- P3: apply the two-question test — fix + resolve if both answers are yes; otherwise record in summary and defer to user
84
88
- P4: record rejection reason in summary
85
89
4.**Commit & push** — single commit covering all non-workflow fixes (workflow fixes are pushed incrementally during step 2)
86
90
5.**Final verification** — once all fixes are applied, confirm every check is green: `GH_PAGER= gh pr checks <PR>`
@@ -94,8 +98,9 @@ Before acting on any review comment or suggestion, classify it by importance:
94
98
```markdown
95
99
| # | Source (comment / CI) | Issue description | Priority | Action taken | Reason if not fixed |
0 commit comments