Skip to content
This repository was archived by the owner on Dec 2, 2019. It is now read-only.

Commit 18afb0c

Browse files
author
Wendell
committed
🔖 release 0.1.0 with Angular 8 support
1 parent fe210fd commit 18afb0c

File tree

9 files changed

+32
-32
lines changed

9 files changed

+32
-32
lines changed
File renamed without changes.

package.json

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,31 +11,31 @@
1111
},
1212
"private": true,
1313
"dependencies": {
14-
"@angular/animations": "~7.2.0",
15-
"@angular/common": "~7.2.0",
16-
"@angular/compiler": "~7.2.0",
17-
"@angular/core": "~7.2.0",
18-
"@angular/forms": "~7.2.0",
19-
"@angular/platform-browser": "~7.2.0",
20-
"@angular/platform-browser-dynamic": "~7.2.0",
21-
"@angular/router": "~7.2.0",
14+
"@angular/animations": "~8.0.0",
15+
"@angular/common": "~8.0.0",
16+
"@angular/compiler": "~8.0.0",
17+
"@angular/core": "~8.0.0",
18+
"@angular/forms": "~8.0.0",
19+
"@angular/platform-browser": "~8.0.0",
20+
"@angular/platform-browser-dynamic": "~8.0.0",
21+
"@angular/router": "~8.0.0",
2222
"@silicic/share-styles": "0.0.1",
2323
"core-js": "^2.5.4",
2424
"ng-zorro-antd": "^7.4.1",
25-
"rxjs": "~6.3.3",
25+
"rxjs": "~6.5.2",
2626
"tslib": "^1.9.0",
27-
"zone.js": "~0.8.26"
27+
"zone.js": "~0.9.1"
2828
},
2929
"devDependencies": {
30-
"@angular-devkit/build-angular": "~0.13.0",
31-
"@angular-devkit/build-ng-packagr": "~0.13.0",
32-
"@angular/cli": "~7.3.8",
33-
"@angular/compiler-cli": "~7.2.0",
34-
"@angular/language-service": "~7.2.0",
30+
"@angular-devkit/build-angular": "~0.800.0",
31+
"@angular-devkit/build-ng-packagr": "~0.800.0",
32+
"@angular/cli": "~8.0.1",
33+
"@angular/compiler-cli": "~8.0.0",
34+
"@angular/language-service": "~8.0.0",
3535
"@types/jasmine": "~2.8.8",
3636
"@types/jasminewd2": "~2.0.3",
3737
"@types/node": "~8.9.4",
38-
"codelyzer": "~4.5.0",
38+
"codelyzer": "^5.0.1",
3939
"jasmine-core": "~2.99.1",
4040
"jasmine-spec-reporter": "~4.2.1",
4141
"karma": "~4.0.0",
@@ -44,12 +44,12 @@
4444
"karma-jasmine": "~1.1.2",
4545
"karma-jasmine-html-reporter": "^0.2.2",
4646
"monaco-editor": "^0.17.0",
47-
"ng-packagr": "^4.2.0",
47+
"ng-packagr": "^5.2.0",
4848
"protractor": "~5.4.0",
4949
"ts-node": "~7.0.0",
5050
"tsickle": ">=0.34.0",
5151
"tslib": "^1.9.0",
5252
"tslint": "~5.11.0",
53-
"typescript": "~3.2.2"
53+
"typescript": "~3.4.5"
5454
}
5555
}

projects/monaco-ng/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@silicic/monaco-ng",
3-
"version": "0.0.1",
3+
"version": "0.1.0",
44
"author": {
55
"name": "Wendell Hu",
66
"email": "wendzhue@gmail.com"
@@ -22,8 +22,8 @@
2222
"silicic"
2323
],
2424
"peerDependencies": {
25-
"@angular/common": "^7.2.0",
26-
"@angular/core": "^7.2.0",
25+
"@angular/common": "^8.0.0",
26+
"@angular/core": "^8.0.0",
2727
"monaco-editor": "^0.13.0"
2828
}
2929
}

projects/monaco-ng/src/lib/components/monaco.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ export class MonacoComponent
9090
}
9191

9292
ngOnDestroy(): void {
93+
this.editorInstance.dispose();
94+
9395
this.destroy$.next();
9496
this.destroy$.complete();
9597
}
@@ -140,8 +142,6 @@ export class MonacoComponent
140142
...selfOpt,
141143
...forcedOpt
142144
};
143-
144-
console.log(this.editorOptionCached);
145145
this.updateOptionToMonaco();
146146
});
147147
}

projects/monaco-ng/src/lib/monaco.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Inject, Injectable } from '@angular/core';
2-
import { DOCUMENT } from '@angular/platform-browser';
2+
import { DOCUMENT } from "@angular/common";
33
import { BehaviorSubject, Observable, of as observableOf, Subject } from 'rxjs';
44
import { map, tap } from 'rxjs/operators';
55
import { getMonacoScriptsCannotBeLoadedError } from './errors';

src/app/app.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { DOCUMENT } from '@angular/common';
12
import { Component, Inject, OnInit, Renderer2 } from '@angular/core';
2-
import { DOCUMENT } from '@angular/platform-browser';
33
import { editor } from 'monaco-editor';
44
import { MonacoService } from 'projects/monaco-ng/src/public-api';
55

src/polyfills.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
*
4444
* (window as any).__Zone_disable_requestAnimationFrame = true; // disable patch requestAnimationFrame
4545
* (window as any).__Zone_disable_on_property = true; // disable patch onProperty such as onclick
46-
* (window as any).__zone_symbol__BLACK_LISTED_EVENTS = ['scroll', 'mousemove']; // disable patch specified eventNames
46+
* (window as any).__zone_symbol__UNPATCHED_EVENTS = ['scroll', 'mousemove']; // disable patch specified eventNames
4747
*
4848
* in IE/Edge developer tools, the addEventListener will also be wrapped by zone.js
4949
* with the following flag, it will bypass `zone.js` patch for IE/Edge

tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
"outDir": "./dist/out-tsc",
66
"sourceMap": true,
77
"declaration": false,
8-
"module": "es2015",
8+
"module": "esnext",
99
"moduleResolution": "node",
1010
"emitDecoratorMetadata": true,
1111
"experimentalDecorators": true,
1212
"importHelpers": true,
13-
"target": "es5",
13+
"target": "es2015",
1414
"typeRoots": [
1515
"node_modules/@types"
1616
],

tslint.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@
3838
"quotemark": [true, "single"],
3939
"trailing-comma": false,
4040
"no-output-on-prefix": true,
41-
"use-input-property-decorator": true,
42-
"use-output-property-decorator": true,
43-
"use-host-property-decorator": true,
41+
"no-inputs-metadata-property": true,
42+
"no-outputs-metadata-property": true,
43+
"no-host-metadata-property": true,
4444
"no-input-rename": true,
4545
"no-output-rename": true,
46-
"use-life-cycle-interface": true,
46+
"use-lifecycle-interface": true,
4747
"use-pipe-transform-interface": true,
4848
"component-class-suffix": true,
4949
"directive-class-suffix": true

0 commit comments

Comments
 (0)