server: provide list all symbols in package

Author: x1unix

pkg/analyzer/package.go

@@ -50,6 +50,13 @@ func (p *Package) SymbolByChar(chr string) []*CompletionItem {
 	return append(p.Functions.Match(chr), result...)
 }
 
+func (p *Package) AllSymbols() []*CompletionItem {
+	out := make([]*CompletionItem, 0, p.Values.Len()+p.Functions.Len())
+	out = append(out, p.Functions.Symbols...)
+	out = append(out, p.Values.Symbols...)
+	return out
+}
+
 func (p *Package) GetCompletionItem() *CompletionItem {
 	return &CompletionItem{
 		Label:         p.Name,

pkg/analyzer/sym_index.go

@@ -6,6 +6,10 @@ type SymbolIndex struct {
 	charMap map[string][]*CompletionItem
 }
 
+func (si *SymbolIndex) Len() int {
+	return len(si.Symbols)
+}
+
 func emptySymbolIndex() SymbolIndex {
 	return SymbolIndex{
 		Symbols: []*CompletionItem{},

pkg/langserver/server.go

@@ -83,10 +83,6 @@ func (s *Service) lookupBuiltin(val string) (*SuggestionsResponse, error) {
 }
 
 func (s *Service) provideSuggestion(req SuggestionRequest) (*SuggestionsResponse, error) {
-	if req.Value == "" {
-		return nil, fmt.Errorf("empty suggestion request value, nothing to provide")
-	}
-
 	// Provide package suggestions (if requested)
 	if req.PackageName != "" {
 		pkg, ok := s.index.PackageByName(req.PackageName)
@@ -98,11 +94,22 @@ func (s *Service) provideSuggestion(req SuggestionRequest) (*SuggestionsResponse
 			return nil, fmt.Errorf("failed to analyze package %q: %s", req.PackageName, err)
 		}
 
+		var symbols []*analyzer.CompletionItem
+		if req.Value != "" {
+			symbols = pkg.SymbolByChar(req.Value)
+		} else {
+			symbols = pkg.AllSymbols()
+		}
+
 		return &SuggestionsResponse{
-			Suggestions: pkg.SymbolByChar(req.Value),
+			Suggestions: symbols,
 		}, nil
 	}
 
+	if req.Value == "" {
+		return nil, fmt.Errorf("empty suggestion request value, nothing to provide")
+	}
+
 	return s.lookupBuiltin(req.Value)
 }