fix: silence nonminimal bool warnings

Author: robjtede

.cspell.yml

@@ -6,6 +6,7 @@ words:
   - nextest
   - nixos
   - nixpkgs
+  - nonminimal
   - pkgs
   - RUSTDOCFLAGS
   - taplo

examples/library.rs

@@ -24,7 +24,6 @@ impl Library {
         self.available.insert(book_id.to_string());
     }
 
-    #[allow(clippy::nonminimal_bool)]
     #[debug_requires(self.book_exists(book_id))]
     #[ensures(ret -> self.available.len() == old(self.available.len()) - 1)]
     #[ensures(ret -> self.lent.len() == old(self.lent.len()) + 1)]

src/implementation/codegen.rs

@@ -185,15 +185,20 @@ pub(crate) fn generate(
 
         if mode == ContractMode::LogOnly {
             result.extend(quote::quote_spanned! { span=>
-                if !(#exec_expr) {
-                    log::error!("{}", #format_args);
+                #[allow(clippy::nonminimal_bool)]
+                {
+                    if !(#exec_expr) {
+                        log::error!("{}", #format_args);
+                    }
                 }
             });
         }
 
         if let Some(assert_macro) = get_assert_macro(ctype, mode, span) {
             result.extend(quote::quote_spanned! { span=>
-                #assert_macro!(#exec_expr, "{}", #format_args);
+                #[allow(clippy::nonminimal_bool)] {
+                    #assert_macro!(#exec_expr, "{}", #format_args);
+                }
             });
         }
 

tests/implication.rs

@@ -7,7 +7,6 @@ use contracts::*;
 #[cfg(feature = "mirai_assertions")]
 mod mirai_assertion_mocks;
 
-#[allow(clippy::nonminimal_bool)]
 #[test]
 fn test_ret_implication() {
     #[ensures(do_thing -> ret.is_some(), "do_thing should cause a Some(_)")]
@@ -24,7 +23,6 @@ fn test_ret_implication() {
     perform_thing(false);
 }
 
-#[allow(clippy::nonminimal_bool)]
 #[test]
 fn test_ret_implication_old() {
     #[ensures(old(*x) % 2 == 0 -> *x % 2 == 0)]
@@ -40,7 +38,6 @@ fn test_ret_implication_old() {
     incr(&mut x);
 }
 
-#[allow(clippy::nonminimal_bool)]
 #[test]
 fn test_requires_implication() {
     #[requires(!negative -> value >= 0)]

tests/issues.rs

@@ -12,7 +12,6 @@ fn gl_issue_11() {
 
         #[ensures(self.contains_key(key) -> ret.is_some())]
         #[ensures(!self.contains_key(key) -> ret.is_none())]
-        #[ensures(true)]
         pub fn get_mut(&mut self, key: &str) -> Option<&mut u8> {
             None
         }