chore: disallow e binding name

Author: robjtede

.clippy.toml

@@ -0,0 +1,6 @@
+disallowed-names = [
+    "foo",  # placeholder name
+    "baz",  # placeholder name
+    "quux", # placeholder name
+    "e",    # prefer `err`
+]

Cargo.toml

@@ -8,12 +8,6 @@ license = "MIT"
 edition = "2021"
 rust-version = "1.80"
 
-[workspace.lints.rust]
-rust_2018_idioms = "deny"
-nonstandard_style = "deny"
-future_incompatible = "deny"
-missing_debug_implementations = { level = "warn", priority = -1 }
-
 [workspace.dependencies]
 assert_matches = "1"
 bytes = "1.10"
@@ -46,3 +40,13 @@ url = "2"
 [patch.crates-io]
 oas3 = { path = "crates/oas3" }
 roast = { path = "crates/roast" }
+
+[workspace.lints.rust]
+rust-2018-idioms = "deny"
+nonstandard-style = "deny"
+future-incompatible = "deny"
+missing-debug-implementations = { level = "warn", priority = -1 }
+
+[workspace.lints.clippy]
+uninlined-format-args = "warn"
+disallowed-names = "warn"

crates/oas3/src/lib.rs

@@ -84,7 +84,7 @@ mod tests {
     where
         P: AsRef<Path> + std::fmt::Debug,
     {
-        println!("    Saving string to {:?}...", path);
+        println!("    Saving string to {path:?}...");
         std::fs::create_dir_all(&path).unwrap();
         let full_filename = path.as_ref().to_path_buf().join(filename);
         let mut f = File::create(full_filename).unwrap();
@@ -119,7 +119,7 @@ mod tests {
 
         // Read the original file to string
         let spec_yaml_str = read_to_string(input_file)
-            .unwrap_or_else(|e| panic!("failed to read contents of {:?}: {}", input_file, e));
+            .unwrap_or_else(|err| panic!("failed to read contents of {input_file:?}: {err}"));
         // Convert YAML string to JSON string
         let spec_json_str = convert_yaml_str_to_json(&spec_yaml_str);
 
@@ -164,7 +164,7 @@ mod tests {
             let entry = entry.unwrap();
             let path = entry.path();
 
-            println!("Testing if {:?} is deserializable", path);
+            println!("Testing if {path:?} is deserializable");
 
             let (api_filename, parsed_spec_json_str, spec_json_str) =
                 compare_spec_through_json(&path, &save_path_base);

crates/oas3/src/spec/media_type_examples.rs

@@ -73,7 +73,7 @@ impl MediaTypeExamples {
                 .filter_map(|(name, oor)| {
                     oor.resolve(spec)
                         .map(|obj| (name.clone(), obj))
-                        .map_err(|err| error!("{}", err))
+                        .map_err(|err| error!("{err}"))
                         .ok()
                 })
                 .collect(),

crates/oas3/src/spec/operation.rs

@@ -146,7 +146,7 @@ impl Operation {
                 oor.resolve(spec)
                     .map(|obj| (name.clone(), obj))
                     // TODO: find better error solution
-                    .map_err(|err| error!("{}", err))
+                    .map_err(|err| error!("{err}"))
                     .ok()
             })
             .collect()
@@ -158,7 +158,7 @@ impl Operation {
             .parameters
             .iter()
             // TODO: find better error solution, maybe vec<result<_>>
-            .filter_map(|oor| oor.resolve(spec).map_err(|err| error!("{}", err)).ok())
+            .filter_map(|oor| oor.resolve(spec).map_err(|err| error!("{err}")).ok())
             .collect();
 
         Ok(params)

crates/roast/src/conformance/auth.rs

@@ -42,7 +42,7 @@ impl fmt::Debug for TestAuthentication {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
             Self::Custom(_) => write!(f, "[custom auth transformer]"),
-            other => write!(f, "{:?}", other),
+            other => write!(f, "{other:?}"),
         }
     }
 }

crates/roast/src/conformance/runner.rs

@@ -165,7 +165,7 @@ impl TestRunner {
             .map(|(test_spec, test)| {
                 let num = Arc::clone(&num).fetch_sub(1, Ordering::SeqCst);
 
-                println!("running test: {}", num);
+                println!("running test: {num}");
                 trace!("run test: {:?}", &test);
 
                 self.run_test(test).map(|result| (test_spec, result))
@@ -198,7 +198,7 @@ impl TestRunner {
             let test_desc = if let Some(name) = &test.name {
                 let test_name = name.yellow();
                 let op_spec = op.to_string().italic();
-                format!("{}\n{}", test_name, op_spec)
+                format!("{test_name}\n{op_spec}")
             } else {
                 let op_spec = op.to_string().italic();
                 op_spec.to_string()

crates/roast/src/conformance/test.rs

@@ -207,7 +207,7 @@ impl ConformanceTestSpec {
         };
 
         if let Some(TestAuthentication::Bearer(ref jwt)) = self.request.auth {
-            let val = format!("Bearer {}", jwt);
+            let val = format!("Bearer {jwt}");
             req.headers
                 .insert("Authorization", val.parse().expect("invalid auth token"));
         }

crates/roast/src/validation/error.rs

@@ -31,7 +31,7 @@ impl fmt::Display for AggregateError {
         let errs = self
             .errors
             .iter()
-            .map(|err| format!("  => {}", err))
+            .map(|err| format!("  => {err}"))
             .collect::<Vec<_>>()
             .join("\n");
 

crates/roast/src/validation/validator.rs

@@ -37,7 +37,7 @@ impl ValidationTree {
         };
 
         if let Some(type_) = &schema.schema_type {
-            trace!("restricting data type: {:?}", type_);
+            trace!("restricting data type: {type_:?}");
 
             let type_val = if let Some(nullable) = schema.is_nullable() {
                 DataType::new(type_.clone()).set_nullable(nullable)
@@ -233,7 +233,7 @@ impl ValidationTree {
                 match val {
                     JsonValue::Array(items) => {
                         for (i, item) in items.iter().enumerate() {
-                            let child_path = path.extend(format!("[{}]", i));
+                            let child_path = path.extend(format!("[{i}]"));
                             v.validate_inner(item, child_path)?;
                         }
                     }