Do not .unwrap() on potentially None references
#229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robjtede awawawawawawawawawawawawawawaw |
|
My development laptop was stolen last week so I'm unable to check this out right now. |
|
Oh. I am terribly sorry to hear that D: In that case, no rush! :) |
bitfl0wer
force-pushed
the
flori/no-unwrap-schema-resolve
branch
from
6483ea7 to
4edfea4
Compare
bitfl0wer
changed the title
.unwrap() on potentially None schema.unwrap() on potentially None references
feat: add new `Error` variant `NoReference`
bitfl0wer
force-pushed
the
flori/no-unwrap-schema-resolve
branch
from
4edfea4 to
e2cf38b
Compare
|
What do you think about instead, either:
|
|
Looking at the option-ality of these fields, I think this is the correct solution for the library: #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered
atwo separate program-crashing errors, where, when calling.schema(&spec)on aMediaTypeor.request_body(&spec)on aRequestBody, the program will panic, if the innerOption<ObjectOrReference<_>>>isNone. This should not happen, especially because the methods in question already return aResult<T, E>type, which allow for error handling at the call site.This PR simply substitutes the
unwrap()calls with anok_or()-call, which yields a newly definedRefErrorvariant "NoRef", if the innerOption<ObjectOrReference<_>>>isNone.Edit: Since I have also encountered the original error when trying to resolve a potentially
NoneRequestBodyreference, I updated the PR to fix that.unwrap()call as well.