Skip to content
This repository was archived by the owner on Apr 11, 2025. It is now read-only.

Commit 3438b34

Browse files
committed
remove comments, log channel errors
Signed-off-by: strawberry <[email protected]>
1 parent 68321ec commit 3438b34

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

src/service/admin/mod.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -183,12 +183,9 @@ impl Service {
183183
}
184184
drop(state_lock);
185185
}
186-
Err(_) => {
187-
// TODO: Handle error, Im too unfamiliar with the codebase to know what to do here
188-
189-
190-
// recv_async returns an error if all senders have been dropped. If the channel is empty, the returned future will yield to the async runtime.
191-
186+
Err(e) => {
187+
// generally shouldn't happen
188+
error!("Failed to receive admin room event from channel: {e}");
192189
}
193190
}
194191
}

src/service/presence/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,8 @@ impl Service {
181181
presence_timers.push(presence_timer(user_id, timeout));
182182
}
183183
Err(e) => {
184-
// TODO: Handle error better? I have no idea what to do here.
185-
error!("Failed to receive presence timer: {}", e);
184+
// generally shouldn't happen
185+
error!("Failed to receive presence timer through channel: {e}");
186186
}
187187
}
188188
}

src/service/sending/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ impl Service {
342342
},
343343

344344
event = receiver.recv_async() => {
345-
// TODO: Error handling for this
346345
if let Ok((outgoing_kind, event, key)) = event {
347346
if let Ok(Some(events)) = self.select_events(
348347
&outgoing_kind,

0 commit comments

Comments
 (0)