go over map cursor lag one last time

Author: xGinko

AnarchyExploitFixesFolia/src/main/java/me/xginko/aef/modules/packets/MapCursorLag.java

@@ -17,25 +17,28 @@ public MapCursorLag() {
         super("patches.map-cursor-lag-patch", false, PacketListenerPriority.HIGHEST, """
                 Patches the famous stacked map cursor lag that causes both client and server lag.""");
         this.maxCursors = config.getInt(configPath + ".max-cursors", 32);
-        this.disableTracking = config.getBoolean(configPath + ".disable-tracking", false,
+        this.disableTracking = config.getBoolean(configPath + ".disable-tracking", true,
                 "Disables all tracking on active MapViews.");
     }
 
     @Override
     public void onPacketSend(PacketSendEvent event) {
         if (event.getPacketType() != PacketType.Play.Server.MAP_DATA) return;
+
         WrapperPlayServerMapData mapData = new WrapperPlayServerMapData(event);
 
-        MapView bukkitMapView = ItemUtil.getMapById(mapData.getMapId());
-        if (bukkitMapView != null && !bukkitMapView.isVirtual()) {
-            ItemUtil.setTrackingMapPosition(bukkitMapView, !disableTracking);
+        if (disableTracking) {
+            MapView bukkitMapView = ItemUtil.getMapById(mapData.getMapId());
+            if (bukkitMapView != null && !bukkitMapView.isVirtual()) {
+                ItemUtil.setTrackingMapPosition(bukkitMapView, false);
+            }
         }
 
         if (mapData.getDecorations() != null) {
             while (mapData.getDecorations().size() > maxCursors) {
                 mapData.getDecorations().remove(GenericUtil.RANDOM.nextInt(mapData.getDecorations().size()));
+                event.markForReEncode(true);
             }
-            event.markForReEncode(true);
         }
     }
 }

AnarchyExploitFixesLegacy/src/main/java/me/xginko/aef/modules/packets/MapCursorLag.java

@@ -30,17 +30,19 @@ public void onPacketSend(PacketSendEvent event) {
 
         WrapperPlayServerMapData mapData = new WrapperPlayServerMapData(event);
 
-        MapView bukkitMapView = Platform.getServerVersion().isOlderThanOrEquals(ServerVersion.V_1_12_2) ?
-                Bukkit.getMap((short) mapData.getMapId()) : ItemUtil.getMapById(mapData.getMapId());
-        if (bukkitMapView != null && !bukkitMapView.isVirtual()) {
-            ItemUtil.setTrackingMapPosition(bukkitMapView, !disableTracking);
+        if (disableTracking) {
+            MapView bukkitMapView = Platform.getServerVersion().isOlderThanOrEquals(ServerVersion.V_1_12_2) ?
+                    Bukkit.getMap((short) mapData.getMapId()) : ItemUtil.getMapById(mapData.getMapId());
+            if (bukkitMapView != null && !bukkitMapView.isVirtual()) {
+                ItemUtil.setTrackingMapPosition(bukkitMapView, false);
+            }
         }
 
         if (mapData.getDecorations() != null) {
             while (mapData.getDecorations().size() > maxCursors) {
                 mapData.getDecorations().remove(GenericUtil.RANDOM.nextInt(mapData.getDecorations().size()));
+                event.markForReEncode(true);
             }
-            event.markForReEncode(true);
         }
     }
 }

shared/src/main/java/me/xginko/aef/utils/ItemUtil.java

@@ -159,11 +159,11 @@ private static int getApproximateByteSizeLegacy(@NotNull BookMeta bookMeta, bool
     }
 
     /**
-     * Disables that a position cursor will be shown when the map is near its center.
+     * Sets whether a position cursor should be shown when the map is near its center.
      */
-    public static void setTrackingMapPosition(@NotNull MapView mapView, boolean tracking) {
+    public static void setTrackingMapPosition(@NotNull MapView mapView, boolean trackingPosition) {
         if (MAP_SET_TRACKING_POS_AVAILABLE) {
-            mapView.setTrackingPosition(tracking);
+            mapView.setTrackingPosition(trackingPosition);
         }
     }