Merge pull request #5 from xJkit/enhance/warning-message

Enhance/warning message

Author: xJkit

example/package.json

@@ -8,8 +8,8 @@
     "@trendmicro/react-buttons": "^1.3.0",
     "@trendmicro/react-modal": "^2.1.0",
     "prop-types": "^15.6.1",
-    "react": "^16.3.1",
-    "react-dom": "^16.3.1",
+    "react": "^16.3.2",
+    "react-dom": "^16.3.2",
     "react-goodbye": "link:..",
     "react-icons": "^2.2.7",
     "react-modal": "^3.3.2",

example/yarn.lock

@@ -3487,7 +3487,7 @@ interpret@^1.0.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/interpret/-/interpret-1.1.0.tgz#7ed1b1410c6a0e0f78cf95d3b8440c63f78b8614"
 
-invariant@^2.2.1, invariant@^2.2.2:
+invariant@^2.2.1, invariant@^2.2.2, invariant@^2.2.4:
   version "2.2.4"
   resolved "https://registry.yarnpkg.com/invariant/-/invariant-2.2.4.tgz#610f3c92c9359ce1db616e538008d23ff35158e6"
   dependencies:
@@ -5635,9 +5635,9 @@ react-dev-utils@^5.0.1:
     strip-ansi "3.0.1"
     text-table "0.2.0"
 
-react-dom@^16.3.1:
-  version "16.3.1"
-  resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.3.1.tgz#6a3c90a4fb62f915bdbcf6204422d93a7d4ca573"
+react-dom@^16.3.2:
+  version "16.3.2"
+  resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.3.2.tgz#cb90f107e09536d683d84ed5d4888e9640e0e4df"
   dependencies:
     fbjs "^0.8.16"
     loose-envify "^1.1.0"
@@ -5738,9 +5738,9 @@ react-scripts@^1.1.1:
   optionalDependencies:
     fsevents "^1.1.3"
 
-react@^16.3.1:
-  version "16.3.1"
-  resolved "https://registry.yarnpkg.com/react/-/react-16.3.1.tgz#4a2da433d471251c69b6033ada30e2ed1202cfd8"
+react@^16.3.2:
+  version "16.3.2"
+  resolved "https://registry.yarnpkg.com/react/-/react-16.3.2.tgz#fdc8420398533a1e58872f59091b272ce2f91ea9"
   dependencies:
     fbjs "^0.8.16"
     loose-envify "^1.1.0"

package.json

@@ -25,7 +25,9 @@
     "predeploy": "cd example && yarn install && yarn run build",
     "deploy": "gh-pages -d example/build"
   },
-  "dependencies": {},
+  "dependencies": {
+    "invariant": "^2.2.4"
+  },
   "peerDependencies": {
     "react": ">=16.3.0",
     "react-router": ">=4.0.0"
@@ -60,21 +62,12 @@
     "rollup-plugin-postcss": "^1.1.0",
     "rollup-plugin-url": "^1.3.0"
   },
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "jest": {
     "setupTestFrameworkScriptFile": "<rootDir>/scripts/jest.setup.js",
-    "testMatch": [
-      "<rootDir>/__tests__/*.spec.js"
-    ],
-    "collectCoverageFrom": [
-      "src/**/*.{js,jsx}"
-    ],
+    "testMatch": ["<rootDir>/__tests__/*.spec.js"],
+    "collectCoverageFrom": ["src/**/*.{js,jsx}"],
     "coverageDirectory": "coverage",
-    "coverageReporters": [
-      "html",
-      "lcov"
-    ]
+    "coverageReporters": ["html", "lcov"]
   }
 }

src/checkCompatible.js

@@ -1,11 +1,8 @@
 import React, { Fragment, createFactory } from 'react';
 import { Prompt as ReactRouterPrompt } from 'react-router';
+import invariant from 'invariant';
 
-/** check library compatibility */
-import check from './checkCompatible';
-check();
-/** */
-
+const __DEV__ = process.env.NODE_ENV !== 'production';
 const GoodByeContext = React.createContext();
 
 export class Provider extends React.Component {
@@ -15,6 +12,10 @@ export class Provider extends React.Component {
       isShow: false
     };
     this.pass = undefined;
+    invariant(
+      React.createContext,
+      'react-goodbye only support React 16.3+ context api, please upgrade your react to the latest version.'
+    )
   }
 
   handleGetUserConfirm = (message, pass) => {
@@ -56,16 +57,19 @@ export const withGoodBye = BaseRouterComponent => {
   const factory = createFactory(BaseRouterComponent);
   const WithGoodBye = props => (
     <Provider>
-      {({ handleGetUserConfirm }) => factory({
-        ...props,
-        getUserConfirmation: handleGetUserConfirm
-      })}
+      {({ handleGetUserConfirm }) => (
+        factory({
+          ...props,
+          getUserConfirmation: handleGetUserConfirm
+        })
+      )}
     </Provider>
   );
 
-  if (process.env.NODE_ENV !== 'production') {
+  if (__DEV__) {
     const baseRouterName = BaseRouterComponent.displayName || BaseRouterComponent.name || 'Component';
     WithGoodBye.displayName = `withGoodBye(${baseRouterName})`;
+
     return WithGoodBye;
   }
 

src/index.js

@@ -2506,7 +2506,7 @@ ini@~1.3.0:
   version "1.3.5"
   resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927"
 
-invariant@^2.2.0, invariant@^2.2.1, invariant@^2.2.2:
+invariant@^2.2.0, invariant@^2.2.1, invariant@^2.2.2, invariant@^2.2.4:
   version "2.2.4"
   resolved "https://registry.yarnpkg.com/invariant/-/invariant-2.2.4.tgz#610f3c92c9359ce1db616e538008d23ff35158e6"
   dependencies: