made some cleanup in tests

Author: fabpot

src/Symfony/Component/HttpKernel/Tests/Exception/AccessdeniedHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 
-/**
- * Test the AccessDeniedHttpException class.
- */
 class AccessDeniedHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new AccessDeniedHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new AccessDeniedHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new AccessDeniedHttpException();
     }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/BadRequestHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
-/**
- * Test the BadRequestHttpException class.
- */
 class BadRequestHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new BadRequestHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new BadRequestHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new BadRequestHttpException();
     }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/ConflictHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\ConflictHttpException;
 
-/**
- * Test the ConflictHttpException class.
- */
 class ConflictHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new ConflictHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new ConflictHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new ConflictHttpException();
     }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/GoneHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\GoneHttpException;
 
-/**
- * Test the GoneHttpException class.
- */
 class GoneHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new GoneHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new GoneHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new GoneHttpException();
     }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/HttpExceptionTest.php

@@ -4,16 +4,8 @@
 
 use Symfony\Component\HttpKernel\Exception\HttpException;
 
-/**
- * Test the HttpException class.
- */
 class HttpExceptionTest extends \PHPUnit_Framework_TestCase
 {
-    /**
-     * Provides header data for the tests.
-     *
-     * @return array
-     */
     public function headerDataProvider()
     {
         return array(
@@ -28,21 +20,13 @@ public function headerDataProvider()
         );
     }
 
-    /**
-     * Test that the default headers is an empty array.
-     */
     public function testHeadersDefault()
     {
-        $exception = new HttpException(200);
+        $exception = $this->createException();
         $this->assertSame(array(), $exception->getHeaders());
     }
 
     /**
-     * Test that setting the headers using the constructor parameter
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
      * @dataProvider headerDataProvider
      */
     public function testHeadersConstructor($headers)
@@ -52,17 +36,17 @@ public function testHeadersConstructor($headers)
     }
 
     /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
      * @dataProvider headerDataProvider
      */
     public function testHeadersSetter($headers)
     {
-        $exception = new HttpException(200);
+        $exception = $this->createException();
         $exception->setHeaders($headers);
         $this->assertSame($headers, $exception->getHeaders());
     }
+
+    protected function createException()
+    {
+        return new HttpException(200);
+    }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/LengthRequiredHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\LengthRequiredHttpException;
 
-/**
- * Test the LengthRequiredHttpException class.
- */
 class LengthRequiredHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new LengthRequiredHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new LengthRequiredHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new LengthRequiredHttpException();
     }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/MethodNotAllowedHttpExceptionTest.php

@@ -4,26 +4,15 @@
 
 use Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException;
 
-/**
- * Test the MethodNotAllowedHttpException class.
- */
 class MethodNotAllowedHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is set as expected.
-     */
     public function testHeadersDefault()
     {
         $exception = new MethodNotAllowedHttpException(array('GET', 'PUT'));
         $this->assertSame(array('Allow' => 'GET, PUT'), $exception->getHeaders());
     }
 
     /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
      * @dataProvider headerDataProvider
      */
     public function testHeadersSetter($headers)

src/Symfony/Component/HttpKernel/Tests/Exception/NotAcceptableHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException;
 
-/**
- * Test the NotAcceptableHttpException class.
- */
 class NotAcceptableHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new NotAcceptableHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new NotAcceptableHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new NotAcceptableHttpException();
     }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/NotFoundHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
-/**
- * Test the NotFoundHttpException class.
- */
 class NotFoundHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new NotFoundHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new NotFoundHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new NotFoundHttpException();
     }
 }

src/Symfony/Component/HttpKernel/Tests/Exception/PreconditionFailedHttpExceptionTest.php

@@ -4,32 +4,10 @@
 
 use Symfony\Component\HttpKernel\Exception\PreconditionFailedHttpException;
 
-/**
- * Test the PreconditionFailedHttpException class.
- */
 class PreconditionFailedHttpExceptionTest extends HttpExceptionTest
 {
-    /**
-     * Test that the default headers is an empty array.
-     */
-    public function testHeadersDefault()
+    protected function createException()
     {
-        $exception = new PreconditionFailedHttpException();
-        $this->assertSame(array(), $exception->getHeaders());
-    }
-
-    /**
-     * Test that setting the headers using the setter function
-     * is working as expected.
-     *
-     * @param array $headers The headers to set.
-     *
-     * @dataProvider headerDataProvider
-     */
-    public function testHeadersSetter($headers)
-    {
-        $exception = new PreconditionFailedHttpException();
-        $exception->setHeaders($headers);
-        $this->assertSame($headers, $exception->getHeaders());
+        return new PreconditionFailedHttpException();
     }
 }