bug symfony#18399 [Intl] Fix int32 min boundary check (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 42dd362aab4d · 2016-04-01T10:38:22.000+02:00
This PR was merged into the 3.0 branch. Discussion ---------- [Intl] Fix int32 min boundary check | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is the right fix, introduced in a bad merge. Commits ------- f29476e [Intl] Fix int32 min boundary check
diff --git a/src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php b/src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
@@ -851,7 +851,7 @@ private function getInt64Value($value)
             return false;
         }
 
-        if (PHP_INT_SIZE !== 8 && ($value > self::$int32Max || $value <= -self::$int32Max - 1)) {
+        if (PHP_INT_SIZE !== 8 && ($value > self::$int32Max || $value < -self::$int32Max - 1)) {
             return (float) $value;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -851,7 +851,7 @@ private function getInt64Value($value)`
`851`	`851`	`return false;`
`852`	`852`	`}`
`853`	`853`
`854`		`- if (PHP_INT_SIZE !== 8 && ($value > self::$int32Max \|\| $value <= -self::$int32Max - 1)) {`
	`854`	`+ if (PHP_INT_SIZE !== 8 && ($value > self::$int32Max \|\| $value < -self::$int32Max - 1)) {`
`855`	`855`	`return (float) $value;`
`856`	`856`	`}`
`857`	`857`