bug symfony#17112 [PropertyAccess] Reorder elements array after PropertyPathBuilder::replace (alekitto)

This PR was merged into the 2.3 branch.

Discussion
----------

[PropertyAccess] Reorder elements array after PropertyPathBuilder::replace

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#17102
| License       | MIT
| Doc PR        |

Commits
-------

d0c0294 [PropertyAccess] Reorder elements array after PropertyPathBuilder::replace

Author: Tobion

src/Symfony/Component/PropertyAccess/PropertyPathBuilder.php

@@ -142,6 +142,7 @@ public function replace($offset, $length, $path, $pathOffset = 0, $pathLength =
             $this->elements[$offset + $i] = $path->getElement($pathOffset + $i);
             $this->isIndex[$offset + $i] = $path->isIndex($pathOffset + $i);
         }
+        ksort($this->elements);
     }
 
     /**

src/Symfony/Component/PropertyAccess/Tests/PropertyPathBuilderTest.php

@@ -252,6 +252,17 @@ public function testReplaceWithLongerPath()
         $this->assertEquals($path, $builder->getPropertyPath());
     }
 
+    public function testReplaceWithLongerPathKeepsOrder()
+    {
+        $path = new PropertyPath('new1.new2.new3');
+        $expected = new PropertyPath('new1.new2.new3.old2');
+
+        $builder = new PropertyPathBuilder(new PropertyPath('old1.old2'));
+        $builder->replace(0, 1, $path);
+
+        $this->assertEquals($expected, $builder->getPropertyPath());
+    }
+
     public function testRemove()
     {
         $this->builder->remove(3);