minor symfony#18392 [ci] Skip dns-sensitive tests when DnsMock is not found (nicolas-grekas)

fabpot · fabpot · commit 9d45acc6a5c9 · 2016-04-01T08:07:56.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- [ci] Skip dns-sensitive tests when DnsMock is not found | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#18319 | License | MIT | Doc PR | - Commits ------- 7e01187 [ci] Skip dns-sensitive tests when DnsMock is not found
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
@@ -93,6 +93,7 @@ public function getInvalidEmails()
 
     /**
      * @dataProvider getDnsChecks
+     * @requires function Symfony\Bridge\PhpUnit\DnsMock::withMockedHosts
      */
     public function testDnsChecks($type, $violation)
     {
@@ -126,6 +127,9 @@ public function getDnsChecks()
         );
     }
 
+    /**
+     * @requires function Symfony\Bridge\PhpUnit\DnsMock::withMockedHosts
+     */
     public function testHostnameIsProperlyParsed()
     {
         DnsMock::withMockedHosts(array('baz.com' => array(array('type' => 'MX'))));

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ public function getInvalidEmails()`
`93`	`93`
`94`	`94`	`/**`
`95`	`95`	`* @dataProvider getDnsChecks`
	`96`	`+ * @requires function Symfony\Bridge\PhpUnit\DnsMock::withMockedHosts`
`96`	`97`	`*/`
`97`	`98`	`public function testDnsChecks($type, $violation)`
`98`	`99`	`{`
`@@ -126,6 +127,9 @@ public function getDnsChecks()`
`126`	`127`	`);`
`127`	`128`	`}`
`128`	`129`
	`130`	`+ /**`
	`131`	`+ * @requires function Symfony\Bridge\PhpUnit\DnsMock::withMockedHosts`
	`132`	`+ */`
`129`	`133`	`public function testHostnameIsProperlyParsed()`
`130`	`134`	`{`
`131`	`135`	`DnsMock::withMockedHosts(array('baz.com' => array(array('type' => 'MX'))));`