Skip to content

Commit a14bcc6

Browse files
committed
minor symfony#17807 [HttpFoundation] [Session] Removed unnecessary PHP version check (Calin Mihai Pristavu)
This PR was merged into the 3.0 branch. Discussion ---------- [HttpFoundation] [Session] Removed unnecessary PHP version check | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony#17805 | License | MIT Fixes symfony#17805 Commits ------- c0e41f9 [HttpFoundation] [Session] Removed unnecessary PHP version check as minimum requirement is now 5.5.9
2 parents c80c8b7 + c0e41f9 commit a14bcc6

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -182,12 +182,7 @@ public function setName($name)
182182
public function regenerate($destroy = false, $lifetime = null)
183183
{
184184
// Cannot regenerate the session ID for non-active sessions.
185-
if (PHP_VERSION_ID >= 50400 && \PHP_SESSION_ACTIVE !== session_status()) {
186-
return false;
187-
}
188-
189-
// Check if session ID exists in PHP 5.3
190-
if (PHP_VERSION_ID < 50400 && '' === session_id()) {
185+
if (\PHP_SESSION_ACTIVE !== session_status()) {
191186
return false;
192187
}
193188

0 commit comments

Comments
 (0)