minor symfony#10701 Made types used by Symfony compatible with the ones of Hack (fabpot)

This PR was merged into the 2.3 branch.

Discussion
----------

Made types used by Symfony compatible with the ones of Hack

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

PHP supports several ways to express types: like Boolean/bool or integer/int. Hack only supports one of them, so this PR proposes to use the Hack type to make Symfony a bit more "compatible" with Hack (gradual upgrade ;)).

Commits
-------

3c9c10f made phpdoc types consistent with those defined in Hack
0555b7f made types consistent with those defined in Hack

Author: fabpot

src/Symfony/Bridge/Monolog/Tests/Processor/WebProcessorTest.php

@@ -60,7 +60,7 @@ public function testUsesRequestServerData()
     }
 
     /**
-     * @param integer $level
+     * @param int     $level
      * @param string  $message
      *
      * @return array Record

src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/Fixtures/php/lazy_service.php

@@ -39,7 +39,7 @@ public function __construct()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @param boolean $lazyLoad whether to try lazy-loading the service with a proxy
+     * @param bool    $lazyLoad whether to try lazy-loading the service with a proxy
      *
      * @return stdClass A stdClass instance.
      */

src/Symfony/Bridge/Swiftmailer/DataCollector/MessageDataCollector.php

@@ -34,7 +34,7 @@ class MessageDataCollector extends DataCollector
      * to avoid the creation of these objects when no emails are sent.
      *
      * @param ContainerInterface $container A ContainerInterface instance
-     * @param Boolean            $isSpool
+     * @param bool               $isSpool
      */
     public function __construct(ContainerInterface $container, $isSpool)
     {

src/Symfony/Bridge/Twig/Extension/CodeExtension.php

@@ -157,7 +157,7 @@ public function fileExcerpt($file, $line)
      * Formats a file path.
      *
      * @param string  $file An absolute file path
-     * @param integer $line The line number
+     * @param int     $line The line number
      * @param string  $text Use this text for the link rather than the file path
      *
      * @return string
@@ -186,7 +186,7 @@ public function formatFile($file, $line, $text = null)
      * Returns the link for a given file/line pair.
      *
      * @param string  $file An absolute file path
-     * @param integer $line The line number
+     * @param int     $line The line number
      *
      * @return string A link of false
      */

src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php

@@ -412,7 +412,7 @@ protected function resolveServiceDefinition($serviceId)
      * Renders list of tagged services grouped by tag
      *
      * @param OutputInterface $output
-     * @param Boolean         $showPrivate
+     * @param bool            $showPrivate
      */
     protected function outputTags(OutputInterface $output, $showPrivate = false)
     {

src/Symfony/Bundle/FrameworkBundle/Controller/Controller.php

@@ -38,7 +38,7 @@ class Controller extends ContainerAware
      *
      * @param string         $route         The name of the route
      * @param mixed          $parameters    An array of parameters
-     * @param Boolean|string $referenceType The type of reference (one of the constants in UrlGeneratorInterface)
+     * @param bool|string    $referenceType The type of reference (one of the constants in UrlGeneratorInterface)
      *
      * @return string The generated URL
      *
@@ -70,7 +70,7 @@ public function forward($controller, array $path = array(), array $query = array
      * Returns a RedirectResponse to the given URL.
      *
      * @param string  $url    The URL to redirect to
-     * @param integer $status The status code to use for the Response
+     * @param int     $status The status code to use for the Response
      *
      * @return RedirectResponse
      */

src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php

@@ -36,8 +36,8 @@ class RedirectController extends ContainerAware
      *
      * @param Request       $request          The request instance
      * @param string        $route            The route name to redirect to
-     * @param Boolean       $permanent        Whether the redirection is permanent
-     * @param Boolean|array $ignoreAttributes Whether to ignore attributes or an array of attributes to ignore
+     * @param bool          $permanent        Whether the redirection is permanent
+     * @param bool|array    $ignoreAttributes Whether to ignore attributes or an array of attributes to ignore
      *
      * @return Response A Response instance
      *
@@ -72,10 +72,10 @@ public function redirectAction(Request $request, $route, $permanent = false, $ig
      *
      * @param Request      $request   The request instance
      * @param string       $path      The absolute path or URL to redirect to
-     * @param Boolean      $permanent Whether the redirect is permanent or not
+     * @param bool         $permanent Whether the redirect is permanent or not
      * @param string|null  $scheme    The URL scheme (null to keep the current one)
-     * @param integer|null $httpPort  The HTTP port (null to keep the current one for the same scheme or the configured port in the container)
-     * @param integer|null $httpsPort The HTTPS port (null to keep the current one for the same scheme or the configured port in the container)
+     * @param int    |null $httpPort  The HTTP port (null to keep the current one for the same scheme or the configured port in the container)
+     * @param int    |null $httpsPort The HTTPS port (null to keep the current one for the same scheme or the configured port in the container)
      *
      * @return Response A Response instance
      *

src/Symfony/Bundle/FrameworkBundle/Controller/TemplateController.php

@@ -27,7 +27,7 @@ class TemplateController extends ContainerAware
      * @param string       $template  The template name
      * @param int|null     $maxAge    Max age for client caching
      * @param int|null     $sharedAge Max age for shared (proxy) caching
-     * @param Boolean|null $private   Whether or not caching should apply for client caches only
+     * @param bool|null    $private   Whether or not caching should apply for client caches only
      *
      * @return Response A Response instance
      */

src/Symfony/Bundle/FrameworkBundle/HttpCache/HttpCache.php

@@ -46,7 +46,7 @@ public function __construct(HttpKernelInterface $kernel, $cacheDir = null)
      * Forwards the Request to the backend and returns the Response.
      *
      * @param Request  $request A Request instance
-     * @param Boolean  $raw     Whether to catch exceptions or not
+     * @param bool     $raw     Whether to catch exceptions or not
      * @param Response $entry   A Response instance (the stale entry if present, null otherwise)
      *
      * @return Response A Response instance

src/Symfony/Bundle/FrameworkBundle/Templating/GlobalVariables.php

@@ -112,6 +112,6 @@ public function getEnvironment()
      */
     public function getDebug()
     {
-        return (Boolean) $this->container->getParameter('kernel.debug');
+        return (bool) $this->container->getParameter('kernel.debug');
     }
 }