Skip to content

Commit c6da106

Browse files
Merge branch '2.3' into 2.7
* 2.3: [travis] Load memcache.so [2.3] Cherry-pick @group time-sensitive annotations [ci] load php_memcache.dll and apcu.so Conflicts: .travis.yml src/Symfony/Component/Console/Tests/Helper/LegacyProgressHelperTest.php
2 parents 840e7a9 + ed40dc3 commit c6da106

17 files changed

+32
-255
lines changed

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@ before_install:
3232
- if [[ "$TRAVIS_PHP_VERSION" != "hhvm" ]]; then echo "memory_limit = -1" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini; fi;
3333
- if [[ "$TRAVIS_PHP_VERSION" = 5.* ]]; then phpenv config-rm xdebug.ini; fi;
3434
- if [[ "$TRAVIS_PHP_VERSION" = 5.* ]]; then echo "extension = mongo.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini; fi;
35-
- if [[ "$TRAVIS_PHP_VERSION" =~ 5.[34] ]]; then echo -e "extension = apc.so\napc.enable_cli = 1" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini; fi;
36-
- if [[ "$TRAVIS_PHP_VERSION" = 5.* ]]; then (pecl install -f memcached-2.1.0 && echo "extension = memcache.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini) || echo "Let's continue without memcache extension"; fi;
35+
- if [[ "$TRAVIS_PHP_VERSION" = 5.* ]]; then echo "extension = memcache.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini; fi;
36+
- if [[ "$TRAVIS_PHP_VERSION" = 5.* ]]; then (echo yes | pecl install -f apcu-4.0.7 && echo "apc.enable_cli = 1" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini) || echo "Let's continue without apcu extension"; fi;
37+
- if [[ "$TRAVIS_PHP_VERSION" = 5.* ]]; then pecl install -f memcached-2.1.0 || echo "Let's continue without memcached extension"; fi;
3738
- if [[ "$TRAVIS_PHP_VERSION" = 5.* ]] && [ "$deps" = "no" ]; then (cd src/Symfony/Component/Debug/Resources/ext && phpize && ./configure && make && echo "extension = $(pwd)/modules/symfony_debug.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini); fi;
3839
- if [[ "$TRAVIS_PHP_VERSION" != "hhvm" ]]; then php -i; fi;
3940
- if [ "$deps" != "skip" ]; then ./phpunit install; fi;

appveyor.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ install:
4040
- IF %PHP%==1 copy /Y php.ini-min php.ini-max
4141
- IF %PHP%==1 echo extension=php_apcu.dll >> php.ini-max
4242
- IF %PHP%==1 echo apc.enable_cli=1 >> php.ini-max
43+
- IF %PHP%==1 echo extension=php_memcache.dll >> php.ini-max
4344
- IF %PHP%==1 echo extension=php_intl.dll >> php.ini-max
4445
- IF %PHP%==1 echo extension=php_mbstring.dll >> php.ini-max
4546
- IF %PHP%==1 echo extension=php_fileinfo.dll >> php.ini-max

src/Symfony/Component/Console/Tests/ClockMock.php

Lines changed: 0 additions & 41 deletions
This file was deleted.

src/Symfony/Component/Console/Tests/Helper/LegacyProgressHelperTest.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,13 @@
1313

1414
use Symfony\Component\Console\Helper\ProgressHelper;
1515
use Symfony\Component\Console\Output\StreamOutput;
16-
use Symfony\Component\Console\Tests;
17-
18-
require_once __DIR__.'/../ClockMock.php';
1916

2017
/**
2118
* @group legacy
19+
* @group time-sensitive
2220
*/
2321
class LegacyProgressHelperTest extends \PHPUnit_Framework_TestCase
2422
{
25-
protected function setUp()
26-
{
27-
Tests\with_clock_mock(true);
28-
}
29-
30-
protected function tearDown()
31-
{
32-
Tests\with_clock_mock(false);
33-
}
34-
3523
public function testAdvance()
3624
{
3725
$progress = new ProgressHelper();

src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,12 @@
1414
use Symfony\Component\Console\Helper\ProgressBar;
1515
use Symfony\Component\Console\Helper\Helper;
1616
use Symfony\Component\Console\Output\StreamOutput;
17-
use Symfony\Component\Console\Tests;
18-
19-
require_once __DIR__.'/../ClockMock.php';
2017

18+
/**
19+
* @group time-sensitive
20+
*/
2121
class ProgressBarTest extends \PHPUnit_Framework_TestCase
2222
{
23-
protected function setUp()
24-
{
25-
Tests\with_clock_mock(true);
26-
}
27-
28-
protected function tearDown()
29-
{
30-
Tests\with_clock_mock(false);
31-
}
32-
3323
public function testMultipleStart()
3424
{
3525
$bar = new ProgressBar($output = $this->getOutputStream());

src/Symfony/Component/HttpFoundation/Tests/ClockMockTestCase.php

Lines changed: 0 additions & 88 deletions
This file was deleted.

src/Symfony/Component/HttpFoundation/Tests/CookieTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@
1818
*
1919
* @author John Kary <[email protected]>
2020
* @author Hugo Hamon <[email protected]>
21+
*
22+
* @group time-sensitive
2123
*/
22-
class CookieTest extends ClockMockTestCase
24+
class CookieTest extends \PHPUnit_Framework_TestCase
2325
{
2426
public function invalidNames()
2527
{

src/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414
use Symfony\Component\HttpFoundation\ResponseHeaderBag;
1515
use Symfony\Component\HttpFoundation\Cookie;
1616

17-
class ResponseHeaderBagTest extends ClockMockTestCase
17+
/**
18+
* @group time-sensitive
19+
*/
20+
class ResponseHeaderBagTest extends \PHPUnit_Framework_TestCase
1821
{
1922
/**
2023
* @covers Symfony\Component\HttpFoundation\ResponseHeaderBag::allPreserveCase

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/LegacyPdoSessionHandlerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
namespace Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler;
1313

1414
use Symfony\Component\HttpFoundation\Session\Storage\Handler\LegacyPdoSessionHandler;
15-
use Symfony\Component\HttpFoundation\Tests\ClockMockTestCase;
1615

1716
/**
1817
* @group legacy
18+
* @group time-sensitive
1919
* @requires extension pdo_sqlite
2020
*/
21-
class LegacyPdoSessionHandlerTest extends ClockMockTestCase
21+
class LegacyPdoSessionHandlerTest extends \PHPUnit_Framework_TestCase
2222
{
2323
private $pdo;
2424

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcacheSessionHandlerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
namespace Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler;
1313

1414
use Symfony\Component\HttpFoundation\Session\Storage\Handler\MemcacheSessionHandler;
15-
use Symfony\Component\HttpFoundation\Tests\ClockMockTestCase;
1615

1716
/**
1817
* @requires extension memcache
18+
* @group time-sensitive
1919
*/
20-
class MemcacheSessionHandlerTest extends ClockMockTestCase
20+
class MemcacheSessionHandlerTest extends \PHPUnit_Framework_TestCase
2121
{
2222
const PREFIX = 'prefix_';
2323
const TTL = 1000;

0 commit comments

Comments
 (0)