bug symfony#14246 [Filesystem] dumpFile() non atomic

Hidde Boomsma · Hidde Boomsma · commit e4015d5cc323 · 2015-12-31T09:33:44.000+01:00
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -477,9 +477,9 @@ public function dumpFile($filename, $content, $mode = 0666)
             throw new IOException(sprintf('Failed to write file "%s".', $filename));
         }
 
-        $this->rename($tmpFile, $filename, true);
         if (null !== $mode) {
-            $this->chmod($filename, $mode);
+            $this->chmod($tmpFile, $mode);
         }
+        $this->rename($tmpFile, $filename, true);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -477,9 +477,9 @@ public function dumpFile($filename, $content, $mode = 0666)`
`477`	`477`	`throw new IOException(sprintf('Failed to write file "%s".', $filename));`
`478`	`478`	`}`
`479`	`479`
`480`		`- $this->rename($tmpFile, $filename, true);`
`481`	`480`	`if (null !== $mode) {`
`482`		`- $this->chmod($filename, $mode);`
	`481`	`+ $this->chmod($tmpFile, $mode);`
`483`	`482`	`}`
	`483`	`+ $this->rename($tmpFile, $filename, true);`
`484`	`484`	`}`
`485`	`485`	`}`