Skip to content

Commit f765956

Browse files
minor symfony#17024 prefer phpunit 5.x on hhvm (eventhorizonpl)
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes symfony#17024). Discussion ---------- prefer phpunit 5.x on hhvm Hi, HHVM is identified as PHP 5.6 compiler. There are some unsolved problems with tests on hhvm, but using a recent phpunit should be a good start point. How about using 5.1? Best regards, Michal | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 7a06d92 prefer phpunit 5.x on hhvm
2 parents 6b13708 + 7a06d92 commit f765956

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

phpunit

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ use Symfony\Component\Process\ProcessUtils;
1818
error_reporting(-1);
1919
require __DIR__.'/src/Symfony/Component/Process/ProcessUtils.php';
2020

21-
// PHPUnit 4.8 does not support PHP 7, while 5.0 requires PHP 5.6+
22-
$PHPUNIT_VERSION = PHP_VERSION_ID >= 70000 ? '5.0' : '4.8';
21+
// PHPUnit 4.8 does not support PHP 7, while 5.1 requires PHP 5.6+
22+
$PHPUNIT_VERSION = PHP_VERSION_ID >= 50600 ? '5.1' : '4.8';
2323
$PHPUNIT_DIR = __DIR__.'/.phpunit';
2424
$PHP = defined('PHP_BINARY') ? PHP_BINARY : 'php';
2525
$PHP = ProcessUtils::escapeArgument($PHP);

0 commit comments

Comments
 (0)