Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Commit 64aefce

Browse files
committed
Remove AppBarLayout.BaseOnOffsetChangedListener binding
This one was causing issues in the java callable wrapper being generated since it wasn't being generated with the generic type argument on the java side. Turns out, this might have caused issues in .NET bindings as well, so for now we are safe to remove it as there are still overloads anywhere `BaseOnOffsetChangedListener` is used that accept `OnOffsetChangedListener` and both interfaces contain the same method (as used in practice).
1 parent 8d384f0 commit 64aefce

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

source/com.android.support/design/transforms/Metadata.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
<attr path="/api/package[@name='android.support.design.animation']/class[@name='DrawableAlphaProperty']/method[@name='get' and count(parameter)=1 and parameter[1][@type='android.graphics.drawable.Drawable']]" name="managedReturn">Java.Lang.Object</attr>
8686
<attr path="/api/package[@name='android.support.design.animation']/class[@name='DrawableAlphaProperty']/method[@name='get' and count(parameter)=1 and parameter[1][@type='android.graphics.drawable.Drawable']]/parameter[1]" name="managedType">Java.Lang.Object</attr>
8787

88-
<attr path="/api/package[@name='android.support.design.widget']/interface[@name='AppBarLayout.OnOffsetChangedListener']/method[@name='onOffsetChanged' and count(parameter)=2 and parameter[1][@type='android.support.design.widget.AppBarLayout'] and parameter[2][@type='int']]/parameter[1]" name="managedType">Java.Lang.Object</attr>
88+
<!-- <attr path="/api/package[@name='android.support.design.widget']/interface[@name='AppBarLayout.OnOffsetChangedListener']/method[@name='onOffsetChanged' and count(parameter)=2 and parameter[1][@type='android.support.design.widget.AppBarLayout'] and parameter[2][@type='int']]/parameter[1]" name="managedType">Java.Lang.Object</attr> -->
8989

9090
<remove-node path="/api/package[@name='android.support.design.circularreveal']/class[@name='CircularRevealWidget.CircularRevealScrimColorProperty']" />
9191
<remove-node path="/api/package[@name='android.support.design.circularreveal']/class[@name='CircularRevealWidget.CircularRevealProperty']" />
@@ -123,6 +123,14 @@
123123

124124
<attr path="/api/package[@name='android.support.design.widget']/interface[@name='TabLayout.OnTabSelectedListener']" name="managedName">IOnTabSelectedListener2</attr>
125125

126+
<!--
127+
OnOffsetChangedListener now implements BaseOnOffsetChangedListener with just the same method
128+
This causes some inheritance problems in .NET so we're going to hide this base interface and make sure everywhere that uses it is patched up and uses OnOffsetChangedListener instead
129+
Luckily for now any methods that take BaseOnOffsetChangedListener also have an overload for OnOffsetChangedListener
130+
-->
131+
<remove-node path="/api/package[@name='android.support.design.widget']/interface[@name='AppBarLayout.BaseOnOffsetChangedListener']" />
132+
<remove-node path="/api/package[@name='android.support.design.widget']/interface[@name='AppBarLayout.OnOffsetChangedListener']/implements[@name='android.support.design.widget.AppBarLayout.BaseOnOffsetChangedListener']" />
133+
126134

127135
<attr path="/api/package[@name='android.support.design.widget']/interface[@name='AppBarLayout.OnOffsetChangedListener']/method[@name='onOffsetChanged']/parameter[1]" name="type">android.support.design.widget.AppBarLayout</attr>
128136
<attr path="/api/package[@name='android.support.design.widget']/interface[@name='AppBarLayout.OnOffsetChangedListener']/method[@name='onOffsetChanged']/parameter[1]" name="managedType">Android.Support.Design.Widget.AppBarLayout</attr>

0 commit comments

Comments
 (0)