Rename MDP to Flyoutpage (#12073)

* - additional renames

* - fix tizen exceptions

* - files

* - flyout pages

* - obsolete

* - fix android references

* - fix android references

* - obsolete attributes

* - remove warnings as errors

* - fix release

Author: PureWeen

Stubs/Xamarin.Forms.Platform.cs

@@ -157,10 +157,27 @@ internal class _CarouselPageRenderer { }
 	[RenderWith (typeof (PageRenderer))]
 	internal class _PageRenderer { }
 
+
+
+
+
+#if !__IOS__ && !TIZEN4_0
+	[RenderWith(typeof(FlyoutPageRenderer))]
+#elif TIZEN4_0
+#pragma warning disable CS0618 // Type or member is obsolete
+	[RenderWith (typeof(MasterDetailPageRenderer))]
+#pragma warning restore CS0618 // Type or member is obsolete
+#else
+	[RenderWith (typeof (PhoneFlyoutPageRenderer))]
+#endif
+	internal class _FlyoutPageRenderer { }
+
 #if !__IOS__ && !TIZEN4_0
-	[RenderWith (typeof (MasterDetailRenderer))]
+	[RenderWith(typeof(Android.AppCompat.MasterDetailPageRenderer))]
 #elif TIZEN4_0
+#pragma warning disable CS0618 // Type or member is obsolete
 	[RenderWith (typeof(MasterDetailPageRenderer))]
+#pragma warning restore CS0618 // Type or member is obsolete
 #else
 	[RenderWith (typeof (PhoneMasterDetailRenderer))]
 #endif

Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs

@@ -55,7 +55,7 @@
 #if PRE_APPLICATION_CLASS
 #elif FORMS_APPLICATION_ACTIVITY
 #else
-[assembly: ExportRenderer(typeof(MasterDetailPage), typeof(NativeDroidMasterDetail))]
+[assembly: ExportRenderer(typeof(FlyoutPage), typeof(NativeDroidFlyoutPage))]
 #endif
 namespace Xamarin.Forms.ControlGallery.Android
 {
@@ -159,13 +159,13 @@ public AttachedStateEffectLabelRenderer(Context context) : base(context)
 		}
 	}
 
-	public class NativeDroidMasterDetail : Xamarin.Forms.Platform.Android.AppCompat.MasterDetailPageRenderer
+	public class NativeDroidFlyoutPage : Xamarin.Forms.Platform.Android.AppCompat.MasterDetailPageRenderer
 	{
-		MasterDetailPage _page;
+		FlyoutPage _page;
 		bool _disposed;
 
 #pragma warning disable 618
-		public NativeDroidMasterDetail()
+		public NativeDroidFlyoutPage()
 #pragma warning restore 618
 		{
 			System.Diagnostics.Debug.WriteLine($">>>>> NativeDroidMasterDetail NativeDroidMasterDetail 53: This is the obsolete constructor being selected");
@@ -180,7 +180,7 @@ protected override void OnElementChanged(VisualElement oldElement, VisualElement
 				return;
 			}
 
-			_page = newElement as MasterDetailPage;
+			_page = newElement as FlyoutPage;
 			_page.PropertyChanged += Page_PropertyChanged;
 			_page.LayoutChanged += Page_LayoutChanged;
 		}

Xamarin.Forms.ControlGallery.iOS/RegistrarValidationService.cs

@@ -21,8 +21,8 @@ public bool Validate(VisualElement element, out string message)
 
 			if (renderer == null 
 				|| renderer.GetType().Name == "DefaultRenderer"
-				|| (element is MasterDetailPage && Device.Idiom == TargetIdiom.Tablet && !(renderer is TabletMasterDetailRenderer))
-				|| (element is MasterDetailPage && Device.Idiom == TargetIdiom.Phone && !(renderer is PhoneMasterDetailRenderer))
+				|| (element is FlyoutPage && Device.Idiom == TargetIdiom.Tablet && !(renderer is TabletMasterDetailRenderer))
+				|| (element is FlyoutPage && Device.Idiom == TargetIdiom.Phone && !(renderer is PhoneMasterDetailRenderer))
 				)
 			{
 				message = $"Failed to load proper iOS renderer for {element.GetType().Name}";

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla22401.cs

@@ -10,8 +10,8 @@ namespace Xamarin.Forms.Controls.Issues
 	[NUnit.Framework.Category(Core.UITests.UITestCategories.Bugzilla)]
 #endif
 	[Preserve(AllMembers = true)]
-	[Issue(IssueTracker.Bugzilla, 22401, "MasterDetailPage detail width broken when landscape", PlatformAffected.iOS, NavigationBehavior.PushAsync)]
-	public class Bugzilla22401 : MasterDetailPage
+	[Issue(IssueTracker.Bugzilla, 22401, "FlyoutPage detail width broken when landscape", PlatformAffected.iOS, NavigationBehavior.PushAsync)]
+	public class Bugzilla22401 : FlyoutPage
 	{
 		public Bugzilla22401()
 		{
@@ -53,7 +53,7 @@ public Bugzilla22401()
 				})
 			};
 
-			Master = new ContentPage { Title = "master", IconImageSource = "menuIcon.png", Content = listView };
+			Flyout = new ContentPage { Title = "master", IconImageSource = "menuIcon.png", Content = listView };
 
 			listView.ItemSelected += (sender, e) =>
 			{

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla25979.cs

@@ -14,7 +14,7 @@ namespace Xamarin.Forms.Controls.Issues
 #endif
 	[Preserve(AllMembers = true)]
 	[Issue(IssueTracker.Bugzilla, 25979, "https://bugzilla.xamarin.com/show_bug.cgi?id=25979")]
-	public class Bugzilla25979 : TestNavigationPage // or TestMasterDetailPage, etc ...
+	public class Bugzilla25979 : TestNavigationPage // or TestFlyoutPage, etc ...
 	{
 		[Preserve(AllMembers = true)]
 		internal sealed class MyPage : ContentPage

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26171.cs

@@ -19,7 +19,7 @@ namespace Xamarin.Forms.Controls.Issues
 #endif
 	[Preserve(AllMembers = true)]
 	[Issue(IssueTracker.Bugzilla, 26171, "Xamarin.Forms.Maps is not updating VisibleRegion property when layout is changed")]
-	public class Bugzilla26171 : TestContentPage // or TestMasterDetailPage, etc ...
+	public class Bugzilla26171 : TestContentPage // or TestFlyoutPage, etc ...
 	{
 		protected override void Init()
 		{

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26993.cs

@@ -17,7 +17,7 @@ namespace Xamarin.Forms.Controls.Issues
 #endif
 	[Preserve(AllMembers = true)]
 	[Issue(IssueTracker.Bugzilla, 26993, "https://bugzilla.xamarin.com/show_bug.cgi?id=26993")]
-	public class Bugzilla26993 : TestContentPage // or TestMasterDetailPage, etc ...
+	public class Bugzilla26993 : TestContentPage // or TestFlyoutPage, etc ...
 	{
 		[Preserve(AllMembers = true)]
 		public class Bz26993ViewCell : ViewCell

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27085.cs

@@ -13,7 +13,7 @@ namespace Xamarin.Forms.Controls.Issues
 	[Category(Core.UITests.UITestCategories.Bugzilla)]
 #endif
 	[Issue(IssueTracker.Bugzilla, 27085, "EntryCell has no possibility to hide keyboard on iOS")]
-	public class Bugzilla27085 : TestContentPage // or TestMasterDetailPage, etc ...
+	public class Bugzilla27085 : TestContentPage // or TestFlyoutPage, etc ...
 	{
 		protected override void Init()
 		{

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs

@@ -18,7 +18,7 @@ namespace Xamarin.Forms.Controls.Issues
 #endif
 	[Preserve(AllMembers = true)]
 	[Issue(IssueTracker.Bugzilla, 27350, "Binding throws Null Pointer Exception when Updating Tab")]
-	public class Bugzilla27350 : TestContentPage // or TestMasterDetailPage, etc ...
+	public class Bugzilla27350 : TestContentPage // or TestFlyoutPage, etc ...
 	{
 		protected override void Init()
 		{

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27642.cs

@@ -15,7 +15,7 @@ namespace Xamarin.Forms.Controls.Issues
 #endif
 	[Preserve(AllMembers = true)]
 	[Issue(IssueTracker.Bugzilla, 27642, "[Windows Phone] Adding a ScrollView control to a ContentView, remove it and re-add it will cause an exception on Windows Phone")]
-	public class Bugzilla27642 : TestContentPage // or TestMasterDetailPage, etc ...
+	public class Bugzilla27642 : TestContentPage // or TestFlyoutPage, etc ...
 	{
 		ContentView _mainContent;
 		protected override void Init()