[Android] Remove missings listeners on dispose (#13569)

Co-authored-by: Kevin Petit <[email protected]>

Author: kvpt

Xamarin.Forms.Platform.Android/Renderers/ButtonRenderer.cs

@@ -90,6 +90,13 @@ protected override void Dispose(bool disposing)
 
 			if (disposing)
 			{
+				if (Control.IsAlive())
+				{
+					Control.SetOnClickListener(null);
+					Control.SetOnTouchListener(null);
+					Control.RemoveOnAttachStateChangeListener(this);
+				}
+
 				_backgroundTracker?.Dispose();
 				_backgroundTracker = null;
 				_visualElementRenderer = null;

Xamarin.Forms.Platform.Android/Renderers/CarouselPageRenderer.cs

@@ -31,8 +31,8 @@ protected override void Dispose(bool disposing)
 			{
 				_previousPage = null;
 
-				if (_viewPager.Adapter != null)
-					_viewPager.Adapter.Dispose();
+				_viewPager.Adapter?.Dispose();
+				_viewPager.ClearOnPageChangeListeners();
 				_viewPager.Dispose();
 				_viewPager = null;
 			}

Xamarin.Forms.Platform.Android/Renderers/EditorRenderer.cs

@@ -196,9 +196,14 @@ protected override void Dispose(bool disposing)
 
 			if (disposing)
 			{
-				if (EditText != null && EditText is IFormsEditText formsEditText)
+				if (EditText != null)
 				{
-					formsEditText.OnKeyboardBackPressed -= OnKeyboardBackPressed;
+					EditText.RemoveTextChangedListener(this);
+
+					if (EditText is IFormsEditText formsEditText)
+					{
+						formsEditText.OnKeyboardBackPressed -= OnKeyboardBackPressed;
+					}
 				}
 			}
 

Xamarin.Forms.Platform.Android/Renderers/EntryRenderer.cs

@@ -205,12 +205,20 @@ protected override void Dispose(bool disposing)
 
 			if (disposing)
 			{
-				if (EditText != null && EditText is IFormsEditText formsEditContext)
+				if (EditText != null)
 				{
-					formsEditContext.OnKeyboardBackPressed -= OnKeyboardBackPressed;
-					formsEditContext.SelectionChanged -= SelectionChanged;
-					ListenForCloseBtnTouch(false);
+					EditText.RemoveTextChangedListener(this);
+					EditText.SetOnEditorActionListener(null);
+
+					if (EditText is IFormsEditText formsEditContext)
+					{
+						formsEditContext.OnKeyboardBackPressed -= OnKeyboardBackPressed;
+						formsEditContext.SelectionChanged -= SelectionChanged;
+						
+						ListenForCloseBtnTouch(false);
+					}
 				}
+
 				_clearBtn = null;
 			}
 

Xamarin.Forms.Platform.Android/Renderers/MasterDetailRenderer.cs

@@ -229,6 +229,8 @@ protected override void Dispose(bool disposing)
 					_masterLayout = null;
 				}
 
+				RemoveDrawerListener(this);
+
 				Device.Info.PropertyChanged -= DeviceInfoPropertyChanged;
 
 				if (_page != null)

Xamarin.Forms.Platform.Android/Renderers/RefreshViewRenderer.cs

@@ -237,9 +237,9 @@ protected override void Dispose(bool disposing)
 					Element.PropertyChanged -= HandlePropertyChanged;
 				}
 
-				if (_renderer != null)
-					_renderer.View.RemoveFromParent();
+				SetOnRefreshListener(null);
 
+				_renderer?.View.RemoveFromParent();
 				_renderer?.Dispose();
 				_renderer = null;
 

Xamarin.Forms.Platform.Android/Renderers/SearchBarRenderer.cs

@@ -22,6 +22,7 @@ public class SearchBarRenderer : ViewRenderer<SearchBar, SearchView>, SearchView
 		TextColorSwitcher _textColorSwitcher;
 		TextColorSwitcher _hintColorSwitcher;
 		float _defaultHeight => Context.ToPixels(42);
+		bool _isDisposed;
 
 		public SearchBarRenderer(Context context) : base(context)
 		{
@@ -348,5 +349,24 @@ protected virtual NumberKeyListener GetDigitsKeyListener(InputTypes inputTypes)
 			// (e.g., inputTypes &= ~InputTypes.NumberFlagSigned to disallow the sign)
 			return LocalizedDigitsKeyListener.Create(inputTypes);
 		}
+
+		protected override void Dispose(bool disposing)
+		{
+			if (_isDisposed)
+				return;
+
+			_isDisposed = true;
+		
+			if (disposing)
+			{
+				if (Control.IsAlive())
+				{
+					Control.SetOnQueryTextListener(null);
+					Control.SetOnQueryTextFocusChangeListener(null);
+				}
+			}
+
+			base.Dispose(disposing);
+		}
 	}
 }

Xamarin.Forms.Platform.Android/Renderers/SliderRenderer.cs

@@ -16,6 +16,7 @@ public class SliderRenderer : ViewRenderer<Slider, SeekBar>, SeekBar.IOnSeekBarC
 		ColorFilter defaultthumbcolorfilter;
 		Drawable defaultthumb;
 		PorterDuff.Mode defaultprogresstintmode, defaultprogressbackgroundtintmode;
+		bool _isDisposed;
 
 		public SliderRenderer(Context context) : base(context)
 		{
@@ -213,5 +214,23 @@ protected override void OnLayout(bool changed, int l, int t, int r, int b)
 
 			thumb.SetBounds(thumb.Bounds.Left, thumbTop, thumb.Bounds.Left + thumb.IntrinsicWidth, thumbTop + thumb.IntrinsicHeight);
 		}
+
+		protected override void Dispose(bool disposing)
+		{
+			if (_isDisposed)
+				return;
+
+			_isDisposed = true;
+		
+			if (disposing)
+			{
+				if (Control.IsAlive())
+				{
+					Control.SetOnSeekBarChangeListener(null);
+				}
+			}
+
+			base.Dispose(disposing);
+		}
 	}
 }