Check for Internet Connection before running tests that Require an Internet Connection (#12790)

PureWeen · web-flow · commit 640377ce98ac · 2020-11-10T09:54:57.000-07:00
* Check for the internet before running internet based tests

* - iOS fixes

* - uwp fixes

* - add additional tests

* - extract categories from the class

* - add additional tests

* Update Xamarin.Forms.ControlGallery.Android.csproj
diff --git a/Xamarin.Forms.ControlGallery.Android/FormsAppCompatActivity.cs b/Xamarin.Forms.ControlGallery.Android/FormsAppCompatActivity.cs
@@ -11,6 +11,8 @@
 using Xamarin.Forms.Platform.Android.AppLinks;
 using System.Linq;
 using Xamarin.Forms.Internals;
+using System.Threading.Tasks;
+using System.Net.Http;
 
 namespace Xamarin.Forms.ControlGallery.Android
 {
@@ -116,6 +118,27 @@ protected override void OnResume()
 			Profile.Stop();
 		}
 
+		[Export("hasInternetAccess")]
+		public bool HasInternetAccess()
+		{
+			try
+			{
+				using (var httpClient = new HttpClient())
+				using (var httpResponse = httpClient.GetAsync(@"https://www.github.com"))
+				{
+					httpResponse.Wait();
+					if (httpResponse.Result.StatusCode == System.Net.HttpStatusCode.OK)
+						return true;
+					else
+						return false;
+				}
+			}
+			catch
+			{
+				return false;
+			}
+		}
+
 		[Export("IsPreAppCompat")]
 		public bool IsPreAppCompat()
 		{
diff --git a/Xamarin.Forms.ControlGallery.Android/Xamarin.Forms.ControlGallery.Android.csproj b/Xamarin.Forms.ControlGallery.Android/Xamarin.Forms.ControlGallery.Android.csproj
@@ -415,4 +415,4 @@
   </ItemGroup>
   <Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" />
   <Import Project="$(SolutionDir)\.nuget\NuGet.targets" Condition="Exists('$(SolutionDir)\.nuget\NuGet.targets')" />
-</Project>
+</Project>
diff --git a/Xamarin.Forms.ControlGallery.iOS/AppDelegate.cs b/Xamarin.Forms.ControlGallery.iOS/AppDelegate.cs
@@ -2,6 +2,8 @@
 using System.Drawing;
 using System.Globalization;
 using System.IO;
+using System.Net.Http;
+using System.Threading.Tasks;
 using CoreGraphics;
 using Foundation;
 using UIKit;
@@ -407,6 +409,27 @@ public int iOSVersion()
 		{
 			return App.IOSVersion;
 		}
+
+		[Export("hasInternetAccess")]
+		public bool HasInternetAccess()
+		{
+			try
+			{
+				using (var httpClient = new HttpClient())
+				using (var httpResponse = httpClient.GetAsync(@"https://www.github.com"))
+				{
+					httpResponse.Wait();
+					if (httpResponse.Result.StatusCode == System.Net.HttpStatusCode.OK)
+						return true;
+					else
+						return false;
+				}
+			}
+			catch
+			{
+				return false;
+			}
+		}
 	}
 
 	[Register("KVOUISlider")]
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue10744.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue10744.cs
@@ -66,6 +66,7 @@ protected override void Init()
 #if UITEST
 		[Test]
 		[NUnit.Framework.Category(Core.UITests.UITestCategories.UwpIgnore)]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void WebViewEvalCrashesOnAndroidWithLongString()
 		{
 			RunningApp.WaitForElement("navigatedLabel");
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue12134.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue12134.cs
@@ -113,6 +113,7 @@ private void SetCookieContainer(WebView wv)
 
 #if UITEST
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void CookiesCorrectlyLoadWithMultipleWebViews()
 		{
 			for (int i = 0; i < 10; i++)
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2354.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2354.cs
@@ -8,12 +8,16 @@
 #if UITEST
 using NUnit.Framework;
 using Xamarin.UITest;
+using Xamarin.Forms.Core.UITests;
 #endif
 
 namespace Xamarin.Forms.Controls.Issues
 {
 #if UITEST
 	[NUnit.Framework.Category(Core.UITests.UITestCategories.Github5000)]
+	[NUnit.Framework.Category(Core.UITests.UITestCategories.Image)]
+	[NUnit.Framework.Category(Core.UITests.UITestCategories.ListView)]
+	[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 #endif
 	[Preserve(AllMembers = true)]
 	[Issue(IssueTracker.Github, 2354, "ListView, ImageCell and disabled source cache and same image url", PlatformAffected.iOS | PlatformAffected.Android)]
@@ -22,10 +26,17 @@ public class Issue2354 : TestContentPage
 		protected override void Init()
 		{
 			var presidents = new List<President>();
-			for (int i = 0; i < 10; i++)
-			{
-				presidents.Add(new President($"Presidente {44 - i}", 1, $"http://static.c-span.org/assets/images/series/americanPresidents/{43 - i}_400.png"));
-			}
+
+			presidents.Add(new President($"Presidente 44", 1, $"https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/Fruits.jpg?raw=true"));
+			presidents.Add(new President($"Presidente 43", 2, $"https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.ControlGallery.Android/Resources/drawable/person.png?raw=true"));
+			presidents.Add(new President($"Presidente 42", 3, $"https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.ControlGallery.Android/Resources/drawable/photo.jpg?raw=true"));
+			presidents.Add(new President($"Presidente 41", 4, $"https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/FlowerBuds.jpg?raw=true"));
+			presidents.Add(new President($"Presidente 40", 5, $"https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/games.png?raw=true"));
+			presidents.Add(new President($"Presidente 39", 6, $"https://github.com/xamarin/Xamarin.Forms/blob/17881ec93d6b3fb0ee5e1a2be46d7eeadef23529/Xamarin.Forms.ControlGallery.Android/Resources/drawable/gear.png?raw=true"));
+			presidents.Add(new President($"Presidente 38", 7, $"https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.ControlGallery.Android/Resources/drawable/xamarinlogo.png?raw=true"));
+			presidents.Add(new President($"Presidente 37", 8, $"https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.ControlGallery.Android/Resources/drawable/xamarinstore.jpg?raw=true"));
+			presidents.Add(new President($"Presidente 36", 9, $"https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.ControlGallery.Android/Resources/drawable/oasis.jpg?raw=true"));
+			presidents.Add(new President($"Presidente 35", 10, $"https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.ControlGallery.Android/Resources/drawable/Vegetables.jpg?raw=true"));
 
 			var header = new Label
 			{
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue4597.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue4597.cs
@@ -180,6 +180,7 @@ public void ImageFromFileSourceAppearsAndDisappearsCorrectly()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void ImageFromUriSourceAppearsAndDisappearsCorrectly()
 		{
 			RunTest(nameof(Image), true);
@@ -193,6 +194,7 @@ public void ButtonFromFileSourceAppearsAndDisappearsCorrectly()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void ButtonFromUriSourceAppearsAndDisappearsCorrectly()
 		{
 			RunTest(nameof(Button), true);
@@ -206,6 +208,7 @@ public void ImageButtonFromFileSourceAppearsAndDisappearsCorrectly()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void ImageButtonFromUriSourceAppearsAndDisappearsCorrectly()
 		{
 			RunTest(nameof(ImageButton), true);
@@ -218,6 +221,7 @@ public void ImageCellFromFileSourceAppearsAndDisappearsCorrectly()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void ImageCellFromUriSourceAppearsAndDisappearsCorrectly()
 		{
 			ImageCellTest(false);
@@ -235,6 +239,7 @@ void ImageCellTest(bool fileSource)
 			SetImageSourceToNull();
 
 			imageVisible = GetImage();
+			Assert.AreEqual(0, imageVisible.Length);
 
 			UITest.Queries.AppResult[] GetImage()
 			{
@@ -301,11 +306,9 @@ void SetupTest(string controlType, bool fileSource)
 				RunningApp.WaitForNoElement(activeTest);
 			}
 
-			var currentSetting = RunningApp.WaitForElement(_switchUriId)[0].ReadText();
-
-			if (fileSource && RunningApp.Query(_imageFromUri).Length == 0)
+			if (fileSource && RunningApp.Query(_imageFromFile).Length == 0)
 				RunningApp.Tap(_switchUriId);
-			else if (!fileSource && RunningApp.Query(_imageFromFile).Length == 0)
+			else if (!fileSource && RunningApp.Query(_imageFromUri).Length == 0)
 				RunningApp.Tap(_switchUriId);
 		}
 #endif
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue9682.xaml.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue9682.xaml.cs
@@ -40,6 +40,7 @@ protected override void Init()
 
 #if UITEST
 		[Test, NUnit.Framework.Category(UITestCategories.Image)]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void MonkiesShouldLoad()
 		{
 			RunningApp.WaitForElement("MonkeyLoadButton");
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/ScreenshotConditionalApp.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/ScreenshotConditionalApp.cs
@@ -473,8 +473,37 @@ public void Restart()
 		}
 #endif
 
+		string[] GetTestCategories()
+		{
+			var testClassName = TestContext.CurrentContext.Test.ClassName;
+
+			// TestContext.CurrentContext.Test.Properties["Category"]
+			// Only gives you the categories on the test itself
+			// There isn't a property I could find that gives you the Categories
+			// on the Test Class
+			return GetType()
+						.Assembly
+						.GetType(testClassName)
+						.GetCustomAttributes(typeof(NUnit.Framework.CategoryAttribute), true)
+						.OfType<NUnit.Framework.CategoryAttribute>()
+						.Select(x => x.Name)
+						.Union(TestContext.CurrentContext.Test.Properties["Category"].OfType<string>())
+						.ToArray();
+		}
+
 		public void TestSetup(Type testType, bool isolate)
 		{
+			if (GetTestCategories().Contains(UITestCategories.RequiresInternetConnection))
+			{
+				var hasInternetAccess = $"{_app.Invoke("hasInternetAccess")}";
+				bool checkInternet;
+
+				if (bool.TryParse(hasInternetAccess, out checkInternet))
+				{
+					if (!checkInternet)
+						Assert.Inconclusive("Device Has No Internet Connection");
+				}
+			}
 
 #if __WINDOWS__
 			RestartIfAppIsClosed();
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
@@ -2,6 +2,7 @@
 using System.Reflection;
 using Xamarin.Forms.CustomAttributes;
 using IOPath = System.IO.Path;
+using System.Linq;
 using NUnit.Framework.Interfaces;
 using Xamarin.Forms.Controls.Issues;
 
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/issue3262.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/issue3262.cs
@@ -15,7 +15,7 @@
 namespace Xamarin.Forms.Controls.Issues
 {
 #if UITEST
-	[Category(UITestCategories.ManualReview)]
+	[Category(UITestCategories.WebView)]
 #endif
 	[Preserve(AllMembers = true)]
 	[Issue(IssueTracker.Github, 3262, "Adding Cookies ability to a WebView...")]
@@ -300,13 +300,15 @@ protected override void Init()
 #if UITEST
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void LoadingPageWithoutCookiesSpecifiedDoesntCrash()
 		{
 			RunningApp.Tap("PageWithoutCookies");
 			RunningApp.WaitForElement("PageWithoutCookies");
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void ChangeDuringNavigating()
 		{
 			RunningApp.WaitForElement("Loaded");
@@ -318,6 +320,7 @@ public void ChangeDuringNavigating()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void AddAdditionalCookieToWebView()
 		{
 			RunningApp.WaitForElement("Loaded");
@@ -329,6 +332,7 @@ public void AddAdditionalCookieToWebView()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void SetToOneCookie()
 		{
 			RunningApp.WaitForElement("Loaded");
@@ -337,6 +341,7 @@ public void SetToOneCookie()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void SetCookieContainerToNullDisablesCookieManagement()
 		{
 			RunningApp.WaitForElement("Loaded");
@@ -348,6 +353,7 @@ public void SetCookieContainerToNullDisablesCookieManagement()
 		}
 
 		[Test]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public void RemoveAllTheCookiesIAdded()
 		{
 			RunningApp.WaitForElement("Loaded");
diff --git a/Xamarin.Forms.Core.UITests.Shared/Tests/Legacy-CellsUITests.cs b/Xamarin.Forms.Core.UITests.Shared/Tests/Legacy-CellsUITests.cs
@@ -140,6 +140,7 @@ public void CellsGalleryImageCellList()
 		[Description("ListView with ImageCells, file access problems")]
 		[UiTest(typeof(ListView))]
 		[UiTest(typeof(ImageCell))]
+		[NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]
 		public async Task CellsGalleryImageUrlCellList()
 		{
 			SelectTest("ImageCell Url List");
diff --git a/Xamarin.Forms.Core.UITests.Shared/UITestCategories.cs b/Xamarin.Forms.Core.UITests.Shared/UITestCategories.cs
@@ -30,6 +30,7 @@ internal static class UITestCategories
 		public const string MasterDetailPage = "MasterDetailPage";
 		public const string Picker = "Picker";
 		public const string ProgressBar = "ProgressBar";
+		public const string RequiresInternetConnection = "RequiresInternetConnection";
 		public const string RootGallery = "RootGallery";
 		public const string ScrollView = "ScrollView";
 		public const string SearchBar = "SearchBar";
diff --git a/Xamarin.Forms.Core.Windows.UITests/WinDriverApp.cs b/Xamarin.Forms.Core.Windows.UITests/WinDriverApp.cs
@@ -203,6 +203,26 @@ public object Invoke(string methodName, object[] arguments)
 				ContextClick(arguments[0].ToString());
 				return null;
 			}
+			
+			if(methodName == "hasInternetAccess")
+			{
+				try
+				{
+					using (var httpClient = new System.Net.Http.HttpClient())
+					using (var httpResponse = httpClient.GetAsync(@"https://www.github.com"))
+					{
+						httpResponse.Wait();
+						if (httpResponse.Result.StatusCode == System.Net.HttpStatusCode.OK)
+							return true;
+						else
+							return false;
+					}
+				}
+				catch
+				{
+					return false;
+				}
+			}
 
 			return null;
 		}

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@ protected override void Init()`
`66`	`66`	`#if UITEST`
`67`	`67`	`[Test]`
`68`	`68`	`[NUnit.Framework.Category(Core.UITests.UITestCategories.UwpIgnore)]`
	`69`	`+ [NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]`
`69`	`70`	`public void WebViewEvalCrashesOnAndroidWithLongString()`
`70`	`71`	`{`
`71`	`72`	`RunningApp.WaitForElement("navigatedLabel");`
Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,7 @@ private void SetCookieContainer(WebView wv)`
`113`	`113`
`114`	`114`	`#if UITEST`
`115`	`115`	`[Test]`
	`116`	`+ [NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]`
`116`	`117`	`public void CookiesCorrectlyLoadWithMultipleWebViews()`
`117`	`118`	`{`
`118`	`119`	`for (int i = 0; i < 10; i++)`
Original file line number	Diff line number	Diff line change
`@@ -180,6 +180,7 @@ public void ImageFromFileSourceAppearsAndDisappearsCorrectly()`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`[Test]`
	`183`	`+ [NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]`
`183`	`184`	`public void ImageFromUriSourceAppearsAndDisappearsCorrectly()`
`184`	`185`	`{`
`185`	`186`	`RunTest(nameof(Image), true);`
`@@ -193,6 +194,7 @@ public void ButtonFromFileSourceAppearsAndDisappearsCorrectly()`
`193`	`194`	`}`
`194`	`195`
`195`	`196`	`[Test]`
	`197`	`+ [NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]`
`196`	`198`	`public void ButtonFromUriSourceAppearsAndDisappearsCorrectly()`
`197`	`199`	`{`
`198`	`200`	`RunTest(nameof(Button), true);`
`@@ -206,6 +208,7 @@ public void ImageButtonFromFileSourceAppearsAndDisappearsCorrectly()`
`206`	`208`	`}`
`207`	`209`
`208`	`210`	`[Test]`
	`211`	`+ [NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]`
`209`	`212`	`public void ImageButtonFromUriSourceAppearsAndDisappearsCorrectly()`
`210`	`213`	`{`
`211`	`214`	`RunTest(nameof(ImageButton), true);`
`@@ -218,6 +221,7 @@ public void ImageCellFromFileSourceAppearsAndDisappearsCorrectly()`
`218`	`221`	`}`
`219`	`222`
`220`	`223`	`[Test]`
	`224`	`+ [NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]`
`221`	`225`	`public void ImageCellFromUriSourceAppearsAndDisappearsCorrectly()`
`222`	`226`	`{`
`223`	`227`	`ImageCellTest(false);`
`@@ -235,6 +239,7 @@ void ImageCellTest(bool fileSource)`
`235`	`239`	`SetImageSourceToNull();`
`236`	`240`
`237`	`241`	`imageVisible = GetImage();`
	`242`	`+ Assert.AreEqual(0, imageVisible.Length);`
`238`	`243`
`239`	`244`	`UITest.Queries.AppResult[] GetImage()`
`240`	`245`	`{`
`@@ -301,11 +306,9 @@ void SetupTest(string controlType, bool fileSource)`
`301`	`306`	`RunningApp.WaitForNoElement(activeTest);`
`302`	`307`	`}`
`303`	`308`
`304`		`- var currentSetting = RunningApp.WaitForElement(_switchUriId)[0].ReadText();`
`305`		`-`
`306`		`- if (fileSource && RunningApp.Query(_imageFromUri).Length == 0)`
	`309`	`+ if (fileSource && RunningApp.Query(_imageFromFile).Length == 0)`
`307`	`310`	`RunningApp.Tap(_switchUriId);`
`308`		`- else if (!fileSource && RunningApp.Query(_imageFromFile).Length == 0)`
	`311`	`+ else if (!fileSource && RunningApp.Query(_imageFromUri).Length == 0)`
`309`	`312`	`RunningApp.Tap(_switchUriId);`
`310`	`313`	`}`
`311`	`314`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@ protected override void Init()`
`40`	`40`
`41`	`41`	`#if UITEST`
`42`	`42`	`[Test, NUnit.Framework.Category(UITestCategories.Image)]`
	`43`	`+ [NUnit.Framework.Category(UITestCategories.RequiresInternetConnection)]`
`43`	`44`	`public void MonkiesShouldLoad()`
`44`	`45`	`{`
`45`	`46`	`RunningApp.WaitForElement("MonkeyLoadButton");`